Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor\k8s.io\apimachinery\pkg\util\managedfields\internal\structuredmerge.go:73:4: unknown field IgnoredFields in struct literal of type merge.Updater #268

Open
anyone0034 opened this issue Nov 13, 2024 · 2 comments

Comments

@anyone0034
Copy link

image

IgnoredFields is miss,how to resolve

@jvilhuber
Copy link

jvilhuber commented Nov 13, 2024

@jpbetz It appears that c68c9ee introduced a backward-incompatible change, removing IgnoredFields and adding IgnoredFilter in its stead:

	// IgnoreFilter filters out ignored fields from a fieldpath.Set.
	IgnoreFilter map[fieldpath.APIVersion]fieldpath.Filter

This is impacting a few downstream projects/dependencies. For me it's apimachinery:

# k8s.io/apimachinery/pkg/util/managedfields/internal
../../../../../go/pkg/mod/k8s.io/apimachinery@v0.31.2/pkg/util/managedfields/internal/structuredmerge.go:56:4: unknown field IgnoredFields in struct literal of type merge.Updater
../../../../../go/pkg/mod/k8s.io/apimachinery@v0.31.2/pkg/util/managedfields/internal/structuredmerge.go:73:4: unknown field IgnoredFields in struct literal of type merge.Updater

I'd recommend adding back the old field in some backwards compatible way. A breaking change should be done via a major version bump, not in a minor bump.

@jvilhuber
Copy link

I do see it's fixed in k8s.io/apimachinery, but there's no release of it yet (v0.32.0 hasn't been released yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants