Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeselector in values.yaml of Helm chart is incorrect #129

Closed
aiyengar2 opened this issue Sep 29, 2023 · 2 comments
Closed

nodeselector in values.yaml of Helm chart is incorrect #129

aiyengar2 opened this issue Sep 29, 2023 · 2 comments

Comments

@aiyengar2
Copy link
Contributor

nodeselector should be nodeSelector:

windows-gmsa/charts/gmsa/values.yaml

Line 35 in 7f48de9

nodeselector: {}

windows-gmsa/charts/gmsa/templates/deployment.yaml

Lines 31 to 33 in 7f48de9

{{- with .Values.nodeSelector }}
{{- toYaml . | nindent 8 }}
{{- end }}

@aiyengar2
Copy link
Contributor Author

Fixed in #128

@aiyengar2 aiyengar2 mentioned this issue Sep 29, 2023
Merged
@marosset
Copy link
Contributor

marosset commented Oct 2, 2023

/closed
Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsturtevant @aiyengar2 @marosset