Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default name_template #323

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Default name_template #323

merged 1 commit into from
Oct 5, 2022

Conversation

Pluies
Copy link
Contributor

@Pluies Pluies commented Oct 5, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove the name_template customisation.

We're making good progress on the release action (woo!), but it's now failing when uploading the binaries:

      • uploading to release                         file=/home/runner/work/zeitgeist/zeitgeist/src/github.com/kubernetes-sigs/zeitgeist/dist/zeitgeist_linux_arm_7/zeitgeist name=zeitgeist
      • failed to upload artifact, will retry        artifact=zeitgeist error=POST https://uploads.github.com/repos/kubernetes-sigs/zeitgeist/releases/79032136/assets?name=zeitgeist: 422 Validation Failed [{Resource:ReleaseAsset Field:name Code:already_exists Message:}] try=3
      • uploading to release                         file=/home/runner/work/zeitgeist/zeitgeist/src/github.com/kubernetes-sigs/zeitgeist/dist/zeitgeist_windows_amd64_v1/zeitgeist.exe name=zeitgeist.exe
      • failed to upload artifact, will retry        artifact=zeitgeist error=POST https://uploads.github.com/repos/kubernetes-sigs/zeitgeist/releases/79032136/assets?name=zeitgeist: 422 Validation Failed [{Resource:ReleaseAsset Field:name Code:already_exists Message:}] try=2

I think the root cause is that we override the name_template for binaries to only include the binary names, which creates a zeitgeist binary for linux armv7, a zeitgeist binary for linux amd64, a zeitgeist binary for linux ppc64 etc etc, and Github isn;t happy when we try to upload all these identically-named assets to the same release.

I removed our name_template customisation, which will return to the default of {{ .Binary }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{ with .Arm }}v{{ . }}{{ end }}{{ with .Mips }}_{{ . }}{{ end }}{{ if not (eq .Amd64 "v1") }}{{ .Amd64 }}{{ end }} as per the docs.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@Pluies Pluies requested a review from cpanato October 5, 2022 08:49
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pluies, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Pluies,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dc86e73 into kubernetes-sigs:master Oct 5, 2022
@Pluies Pluies deleted the fixup/binary-name branch October 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@n3wscott n3wscott Awaiting requested review from n3wscott

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pluies @k8s-ci-robot @saschagrunert