Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override --ignore-daemonsets-utilization for Cluster Autoscaler on a per AWS ASG basis using ASG label #5399

Closed
youwalther65 opened this issue Jan 5, 2023 · 1 comment · Fixed by #5672
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@youwalther65
Copy link

youwalther65 commented Jan 5, 2023

Which component are you using?:
Cluster Autoscaler on AWS

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Especially for smaller node types DaemonSet CPU/memory requests contribute a lot to node CPU/memory requests and therefore sometimes blocking node termination for scale-down. --ignore-daemonsets-utilization is already available as a global CAS option to solve this.

Describe the solution you'd like.:

Similar to the already available approach of AWS ASG labels which override the global cluster-autoscaler settings for the labeled ASGs , see https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md. I 'd like to introduce:

k8s.io/cluster-autoscaler/node-template/autoscaling-options/ignoredaemonsetsutilization: true (overrides ignore-daemonsets-utilization value for that specific ASG)

to override global setting per ASG using this label

@youwalther65 youwalther65 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2023
@youwalther65 youwalther65 changed the title Override --ignoredaemonsets-utilization for Cluster Auroscaler ona per AWS ASG basis using ASG label Override --ignoredaemonsets-utilization for Cluster Auroscaler on a per AWS ASG basis using ASG label Feb 14, 2023
@vadasambar
Copy link
Member

vadasambar commented Apr 10, 2023

Possible alternatives

Set IgnoreDaemonSetsUtilization to true globally so that it applies to all the nodegroups/ASGs. One problem with this (I think) is scale down wouldn't consider node resource utilization accurately because it would always ignore daemonset resource utilization.

@youwalther65 youwalther65 changed the title Override --ignoredaemonsets-utilization for Cluster Auroscaler on a per AWS ASG basis using ASG label Override --ignore-daemonsets-utilization for Cluster Auroscaler on a per AWS ASG basis using ASG label May 23, 2023
@youwalther65 youwalther65 changed the title Override --ignore-daemonsets-utilization for Cluster Auroscaler on a per AWS ASG basis using ASG label Override --ignore-daemonsets-utilization for Cluster Autoscaler on a per AWS ASG basis using ASG label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants