-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InitContainers dont work by default when moving from unversioned client to client-go #142
Comments
@smarterclayton we had dealt with this when we migrated kubernetes to use versioned client. Is initcontainer going to be stable soon? If so, i don't want to import those conversion functions to client-go. |
Looks like initContainers will be available as a field in 1.6 kubernetes/kubernetes#38382 Which "unversioned" version where you using? I don't think those fields were added until 1.6. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I think that is a bad user experience. By default Init Containers or any other alpha feature should work, without requiring any special serialization.
I had to call the following function to make this work https://github.com/kubernetes/kubernetes/blob/master/pkg/api/v1/pod/util.go#L91
which is not part of the client-go code. So i had to duplicate that in my app.
The text was updated successfully, but these errors were encountered: