Add a charter for SIG Scheduling #2462

bsalamat · 2018-08-03T01:50:26Z

No description provided.

bsalamat · 2018-08-03T01:51:33Z

/assign @derekwaynecarr

cblecker · 2018-08-03T20:56:12Z

/committee steering

sig-scheduling/charter.md

k82cn · 2018-08-04T10:14:11Z

sig-scheduling/charter.md

+
+#### Code, Binaries and Services
+
+- Scheduling related features (e.g. Node Affinity)


Suppose ML/Bigdata workload supportings (scheduling part) are in this catalog :)

Yes, the scheduling related requirements of running ML or Bigdata workloads fall into this category.

k82cn · 2018-08-04T10:15:57Z

The charter looks great ! just few question :)

liggitt · 2018-08-06T12:46:05Z

sig-scheduling/charter.md

+- Pod scheduling APIs (with [sig-api-machinery](../sig-api-machinery))
+- Node resource management (with [sig-node](../sig-node))
+- Cluster resource management (with [wg-resource-management](../wg-resource-management))
+- Pod scheduling policies (with [wg-policy](../wg-poicy))


url has a typo

done. Thanks!

spzala · 2018-08-18T01:33:54Z

sig-scheduling/charter.md

+[test grid]: https://k8s-testgrid.appspot.com/sig-scheduling#Summary
+[perf dashboard]: http://perf-dash.k8s.io/
+[sig-governance]: https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md
+[sigs.yaml]: https://github.com/kubernetes/community/blob/master/sigs.yaml#L1434


Use of sigs.yaml with line number for SIG section is not recommended per this changes in the charter template e0d60fd

@bsalamat :) thanks!

derekwaynecarr

A few style issues to address.

Otherwise, I would not share ownership of an area with a working group since working groups work with sig sponsorship. Just name the other SIG or if its unclear who the other SIG is, cite sig-architecture.

derekwaynecarr · 2018-09-12T21:02:03Z

sig-scheduling/charter.md

+more efficient use of cluster resources, and/or enforces placement policies. 
+
+### In scope
+


nit: please link to the README.md file here as well for the sig. i think the template had said the sigs.yaml but i have yet to see a stable link work there.

https://github.com/kubernetes/community/blob/master/sig-node/charter.md#in-scope

gives an example that had settled on with brian.

derekwaynecarr · 2018-09-12T21:04:44Z

sig-scheduling/charter.md

+- Pod scheduling APIs (with [sig-api-machinery](../sig-api-machinery))
+- Node-level resource management (with [sig-node](../sig-node))
+- Cluster-level resource management (with [sig-node](../sig-node) and [sig-storage](../sig-storage))
+- Pod scheduling policies (with [wg-policy](../wg-policy))


SIGs own code, and may sponsor working groups that span sigs.

Is this referring more specifically to PodDisruptionBudget?

hit enter too soon, meaning to say I would expect this to say "Pod Scheduling Policies (with name other sig)" or be more specific on the resource type if needed.

Pod Scheduling Policy is a new concept we are working on with the policy workgroup. I changed the workgroup to sig auth. It defines authorization rules for specifying scheduling requirements, such as tolerations, anti-affinity, etc.

derekwaynecarr · 2018-09-12T21:07:51Z

sig-scheduling/charter.md

+
+- network management ([sig-network](../sig-network))
+- persistent storage management ([sig-storage](../sig-storage))
+- enforcement of resource quota and other admission policies


are you assuming this is sig-apimachinery?

if so, we need to make sure that is covered in their charter. /cc @smarterclayton @bgrant0607 who are primary/secondary reviewers for that once its posted.

I am not sure if SIG scheduling was responsible for developing and maintaining the resource quota feature in the past. It seems to be more aligned with resource management workgroup, but it is fine with me to have it under SIG scheduling.

AFAIK, "resource quota feature" are NOT in scheduling SIG before, but I do not know who's owner. Anyway, I'm also ok to make it under scheduling umbrella.

personally, i think it makes more sense for quota enforcement to be under api-machinery charter, the enforcement works like the garbage collector.

/cc @deads2k @lavalamp -

I definitely consider api machinery to own at least the object count quota. CPU & RAM are maybe not us unless they are done generically. Feel free to add the relevant OWNERs to one of api machinery's subprojects if you like.

Thanks, Daniel. I update the doc accordingly.

derekwaynecarr · 2018-09-12T21:08:46Z

sig-scheduling/charter.md

+Pick one:
+
+1. SIG Technical Leads (x)
+2. Federation of Subprojects


just update this section to "SIG Technical Leads" per
https://github.com/kubernetes/community/blob/master/sig-node/charter.md#subproject-creation

bsalamat

Thanks, @derekwaynecarr! PTAL.

bsalamat · 2018-09-12T21:41:43Z

sig-scheduling/charter.md

+more efficient use of cluster resources, and/or enforces placement policies. 
+
+### In scope
+


bsalamat · 2018-09-12T21:42:29Z

sig-scheduling/charter.md

+- Pod scheduling APIs (with [sig-api-machinery](../sig-api-machinery))
+- Node-level resource management (with [sig-node](../sig-node))
+- Cluster-level resource management (with [sig-node](../sig-node) and [sig-storage](../sig-storage))
+- Pod scheduling policies (with [wg-policy](../wg-policy))


Pod Scheduling Policy is a new concept we are working on with the policy workgroup. I changed the workgroup to sig auth. It defines authorization rules for specifying scheduling requirements, such as tolerations, anti-affinity, etc.

bsalamat · 2018-09-12T21:49:29Z

sig-scheduling/charter.md

+
+- network management ([sig-network](../sig-network))
+- persistent storage management ([sig-storage](../sig-storage))
+- enforcement of resource quota and other admission policies


I am not sure if SIG scheduling was responsible for developing and maintaining the resource quota feature in the past. It seems to be more aligned with resource management workgroup, but it is fine with me to have it under SIG scheduling.

k8s-ci-robot · 2018-09-20T20:07:03Z

@derekwaynecarr: GitHub didn't allow me to request PR reviews from the following users: -.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

personally, i think it makes more sense for quota enforcement to be under api-machinery charter, the enforcement works like the garbage collector.

/cc @deads2k @lavalamp -

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekwaynecarr · 2018-09-20T20:08:09Z

@bsalamat everything looks good, but i think quota enforcement probably should go under api-machinery.

bsalamat · 2018-09-20T20:29:50Z

@derekwaynecarr I am fine with having quota enforcement under api-machinery. The current version of the doc declares it as "out of scope" for SIG scheduling.

derekwaynecarr · 2018-09-21T14:46:41Z

/lgtm
/approve

k8s-ci-robot · 2018-09-21T14:46:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sig-scheduling/OWNERS~~ [derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2018

k8s-ci-robot requested review from cblecker and k82cn August 3, 2018 01:50

k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2018

k8s-ci-robot assigned derekwaynecarr Aug 3, 2018

k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Aug 3, 2018

cblecker requested review from a team and removed request for cblecker and k82cn August 3, 2018 20:56

k82cn reviewed Aug 4, 2018

View reviewed changes

sig-scheduling/charter.md Outdated Show resolved Hide resolved

k82cn reviewed Aug 4, 2018

View reviewed changes

liggitt reviewed Aug 6, 2018

View reviewed changes

bsalamat force-pushed the sig-charter branch from 22af584 to aeff5bb Compare August 6, 2018 18:44

spzala reviewed Aug 18, 2018

View reviewed changes

Add a charter for SIG Scheduling

cfaa425

bsalamat force-pushed the sig-charter branch from aeff5bb to 0ae31aa Compare August 21, 2018 01:01

bsalamat force-pushed the sig-charter branch from 0ae31aa to 1ba86ff Compare September 8, 2018 23:05

derekwaynecarr suggested changes Sep 12, 2018

View reviewed changes

bsalamat force-pushed the sig-charter branch from 1ba86ff to a33b037 Compare September 12, 2018 21:50

bsalamat commented Sep 12, 2018

View reviewed changes

bsalamat force-pushed the sig-charter branch from a33b037 to 2087c16 Compare September 12, 2018 21:53

k8s-ci-robot requested a review from deads2k September 20, 2018 20:07

k8s-ci-robot requested a review from lavalamp September 20, 2018 20:07

fixup! Add a charter for SIG Scheduling

edf85d7

bsalamat force-pushed the sig-charter branch from 2087c16 to edf85d7 Compare September 21, 2018 01:11

derekwaynecarr approved these changes Sep 21, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2018

k8s-ci-robot merged commit 60c132b into kubernetes:master Sep 21, 2018

bsalamat deleted the sig-charter branch September 21, 2018 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a charter for SIG Scheduling #2462

Add a charter for SIG Scheduling #2462

bsalamat commented Aug 3, 2018

bsalamat commented Aug 3, 2018

cblecker commented Aug 3, 2018

k82cn Aug 4, 2018 •

edited

Loading

bsalamat Aug 5, 2018

k82cn commented Aug 4, 2018

liggitt Aug 6, 2018

bsalamat Aug 6, 2018

spzala Aug 18, 2018

bsalamat Aug 21, 2018

spzala Aug 21, 2018

derekwaynecarr left a comment

derekwaynecarr Sep 12, 2018

derekwaynecarr Sep 12, 2018

bsalamat Sep 12, 2018

derekwaynecarr Sep 12, 2018

derekwaynecarr Sep 12, 2018

bsalamat Sep 12, 2018

derekwaynecarr Sep 12, 2018

bsalamat Sep 12, 2018

k82cn Sep 13, 2018 •

edited

Loading

derekwaynecarr Sep 20, 2018

lavalamp Sep 20, 2018

bsalamat Sep 21, 2018

derekwaynecarr Sep 12, 2018

bsalamat left a comment

bsalamat Sep 12, 2018

bsalamat Sep 12, 2018

bsalamat Sep 12, 2018

k8s-ci-robot commented Sep 20, 2018

derekwaynecarr commented Sep 20, 2018

bsalamat commented Sep 20, 2018

derekwaynecarr commented Sep 21, 2018

k8s-ci-robot commented Sep 21, 2018


		#### Code, Binaries and Services

		- Scheduling related features (e.g. Node Affinity)

		more efficient use of cluster resources, and/or enforces placement policies.

		### In scope

Add a charter for SIG Scheduling #2462

Add a charter for SIG Scheduling #2462

Conversation

bsalamat commented Aug 3, 2018

bsalamat commented Aug 3, 2018

cblecker commented Aug 3, 2018

k82cn Aug 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k82cn commented Aug 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k82cn Sep 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsalamat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 20, 2018

derekwaynecarr commented Sep 20, 2018

bsalamat commented Sep 20, 2018

derekwaynecarr commented Sep 21, 2018

k8s-ci-robot commented Sep 21, 2018

k82cn Aug 4, 2018 •

edited

Loading

k82cn Sep 13, 2018 •

edited

Loading