Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIG Release charter to reflect latest changes #5409

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 14, 2021

This patch updates the SIG Release charter to reflect the current
organizational structure.

Which issue(s) this PR fixes:

Closes kubernetes/sig-release#378

/cc @spiffxp @kubernetes/sig-release-leads

This patch updates the SIG Release charter to reflect the current
organizational structure.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot requested a review from spiffxp January 14, 2021 11:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2021
@saschagrunert
Copy link
Member Author

/assign @justaugustus @LappleApple @hasheddan @alejandrox1 @jeremyrickard

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for @spiffxp to take a review pass

Thanks @saschagrunert!

@@ -14,10 +14,11 @@ This charter adheres to the conventions described in the [Kubernetes Charter REA
- Ensuring quality Kubernetes releases
- Defining and staffing release roles to manage the resolution of release blocking criteria
- Defining and driving development processes (e.g. merge queues, cherrypicks) and release processes
(e.g. burndown meetings, cutting beta releases) with the intent of meeting the release schedule
(e.g. burndown meetings, cutting pre-releases) with the intent of meeting the release schedule
- Managing the creation of release specific artifacts, including:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is really the place for it, but did want to call out that the original review that led to opening this issue requested more clarity on the specific binaries, tools, repos, and artifacts that fell under the purview of sig-release. There is a bit of a fuzzy line because almost everything sig-release releases is "owned" by another sig. I plan on having the specific artifacts better documented as part of kubernetes/sig-release#1337, but wanted to make sure @spiffxp knows that is not falling through the cracks.

ref #2919 (comment) and #2919 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a specific list of artifacts better documented via kubernetes/sig-release#1337 satisfies most of my original concern. That said, #2919 (comment) still stands, I would like to see enumeration of what release-engineering owns, but that can also be done out-of-charter and linked

IMO there is overlap on driving development processes w/ SIG Architecture, SIG Contributor Experience and SIG Testing but I'm not concerned enough about the wording here to block

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 14, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @dims
for final approval as current @kubernetes/steering-committee liason

@dims
Copy link
Member

dims commented Jan 15, 2021

/approve

please hold for additional steering reviewers. thanks for updating this!

@liggitt
Copy link
Member

liggitt commented Jan 20, 2021

/lgtm

@mrbobbytables
Copy link
Member

/lgtm

@justaugustus
Copy link
Member

Thanks for the updates, Sascha!
With three Steering members and a SIG Release TL checking in, I'm releasing the hold.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan, justaugustus, saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f34992d into kubernetes:master Jan 24, 2021
@saschagrunert saschagrunert deleted the sig-release-charter branch January 25, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charter clarifications