Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[nginx-ingress-controller] Add annotation to add CORS support #1773

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Sep 22, 2016

This change is Reviewable

@k8s-github-robot k8s-github-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2016
@aledbf aledbf changed the title WIP: [nginx-ingress-controller] Add annotation to add CORS support [nginx-ingress-controller] Add annotation to add CORS support Sep 27, 2016
Copy link

@bprashanth bprashanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the nit fix

}

// ParseAnnotations parses the annotations contained in the ingress
// rule used to indicate if the upstream servers should use SSL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-github-robot
Copy link

[CLA-PING] @aledbf

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


@k8s-github-robot k8s-github-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2016
@aledbf
Copy link
Contributor Author

aledbf commented Sep 27, 2016

I signed it

@k8s-github-robot k8s-github-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2016
@bprashanth bprashanth added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7644348 into kubernetes-retired:master Sep 27, 2016
@aledbf aledbf deleted the cors-support branch September 27, 2016 17:12
@vinay-g
Copy link

vinay-g commented Dec 1, 2016

@aledbf - can you give an example on how to enable cors in ingress, I added annotation ingress.kubernetes.io/enable-cors: "true" but could not get this work. I tried this using nginx-ingress-controller:0.8.3

@aledbf
Copy link
Contributor Author

aledbf commented Dec 1, 2016

@vinay-g this feature is not available in 0.8.3. Next release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants