Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metrics API #2986

Closed
ijl opened this issue Apr 26, 2018 · 65 comments · Fixed by #3504
Closed

Support metrics API #2986

ijl opened this issue Apr 26, 2018 · 65 comments · Fixed by #3504
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@ijl
Copy link

ijl commented Apr 26, 2018

dashboard should read from the metrics APIs in order to be compatible with future kubernetes versions.

heapster is being deprecated (kubernetes-retired/heapster#2022) in favor of metrics-server (https://github.com/kubernetes-incubator/metrics-server).

The current heapster or metrics-server releases can provide the metrics APIs (https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/resource-metrics-api.md). So a single client implementation can support both on I think kubernetes 1.7 or above.

cc #2976, #1310

@bryk bryk added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 25, 2018
@ibrasho
Copy link

ibrasho commented May 26, 2018

I can start working on this.

@bryk
Copy link
Contributor

bryk commented May 28, 2018

Awesome, this is yours then. Enjoy :) Talk to me or @konryd on slack if you need any help.

@gjmzj
Copy link

gjmzj commented Jun 16, 2018

@ibrasho looking forward to your good news.

@ibrasho
Copy link

ibrasho commented Jul 6, 2018

I hadn't had much time to work on this in the past couple of weeks. I'm expecting to be able to put more time into it soon.

I'd appreciate someone with good understanding of the current implementation to run ideas by on Slack or email.

@caiohasouza
Copy link

+1

@maciaszczykm maciaszczykm added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 31, 2018
@chrisbeach
Copy link

+1

@cheynewallace
Copy link

cheynewallace commented Aug 3, 2018 via email

@wohckcin
Copy link

wohckcin commented Aug 4, 2018

+1

2 similar comments
@mylesjao
Copy link

mylesjao commented Aug 6, 2018

+1

@discostur
Copy link

+1

@maciaszczykm maciaszczykm added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 10, 2018
@nikox94
Copy link

nikox94 commented Aug 11, 2018

+1

1 similar comment
@midN
Copy link

midN commented Aug 14, 2018

👍

@llamahunter
Copy link

People, you don't need to each individually comment "+1" to follow this issue. Just subscribe to it using the button to the right.

@marceliwac
Copy link

@llamahunter
Or just use the thumbs up reaction to the original issue post to bump it up...

@marceliwac marceliwac mentioned this issue Aug 18, 2018
6 tasks
@chrisob
Copy link

chrisob commented Sep 5, 2018

Since this didn't make it into the latest release, is it still planned to replace the dependency on Heapster with the metrics API? (@ibrasho ?)

We're having to run Heapster along-side metrics-server in our 1.11 cluster just for the dashboard 😬

@leezout
Copy link

leezout commented Sep 18, 2018

Any news on that ? As right now using k8 1.11.3 and the latest version of the dashboard/heapster/influxdb
I am unable to get the metric system to work.

Metric client health check failed: the server is currently unable to handle the request (get services heapster). Retrying in 30 seconds.

@nicroto
Copy link

nicroto commented Sep 19, 2018

I just want to add that those additional dependencies take quite a bit of resource, too. I hope you will be able to switch to the new API soon. Thanks for working on this.
Cheers!

@jeefy
Copy link
Member

jeefy commented Apr 11, 2019

#3504 Is ready to be reviewed. Please bring any criticisms (constructive or otherwise) and we'll hash this out. :)

@onitake
Copy link
Contributor

onitake commented Apr 11, 2019

@weiqiang333 对不起,标准语言是英语。如果您不会说英语,请使用翻译服务。 (And sorry for my terrible Chinese... I simply used Google Translate...)

@chiefy
Copy link

chiefy commented Jun 27, 2019

As someone who has deployed dashboard w/ heapster, coming back here and trying to figure out if I still need to use heapster, or if I can use metrics-server is very confusing. The wiki still states you have to use heapster?

@labria
Copy link

labria commented Jun 27, 2019

@chiefy this has been merged, but not yet released.

@leezout
Copy link

leezout commented Jun 27, 2019

@labria Do we know the approximate release date for 2.0?

@Vrtak-CZ
Copy link

@leezout see https://github.com/kubernetes/dashboard/milestone/1

@ld-singh
Copy link

ld-singh commented Jul 1, 2019

any idea on new release date for 2.0?

@xspeng
Copy link

xspeng commented Jul 5, 2019

How's this going?

@floreks
Copy link
Member

floreks commented Jul 5, 2019

Check the relases :)

@MarcusNoble
Copy link

Looks like there's a mistake in https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.0-beta1/aio/deploy/recommended.yaml, the deployment refers to kubernetes-dashboard-head while all other resources use kubernetes-dashboard.

I'm also having trouble running this on 1.13. Looks like the dashboard isn't finding the metrics scraper service so isn't starting.

@pratikvasa
Copy link

Ya same issue here..I tried deploying this and it worked. It is not on https though

@ld-singh
Copy link

Anyone faced issue mentioned in #4088 and fixed?

@lz006
Copy link

lz006 commented Aug 1, 2019

same issue here on 1.14

@starplanet
Copy link

Does this problem have been fixed on 1.14?

@maciaszczykm
Copy link
Member

Metrics support is part of v2 beta. Beta is not part of K8s release, we have to make it final then we can update.

@nicklhy
Copy link

nicklhy commented Aug 19, 2019

Same issue on kubernetes V1.15.2

@BskyRui
Copy link

BskyRui commented Sep 4, 2019

Dashboard doesn't support metrics on Kubernetes V1.15.3 🙁

@floreks
Copy link
Member

floreks commented Sep 4, 2019

Any details about that? Version used? Configuration details? Without additional information, I am just assuming this is a configuration issue on your end.

@BskyRui
Copy link

BskyRui commented Sep 5, 2019

Any details about that? Version used? Configuration details? Without additional information, I am just assuming this is a configuration issue on your end.

Kubernets V1.15.3 & Dashboard v1.10.1, I installed metrics successful, After refresh the dashboard page, I can't see the CPU graph. I need to configure something?

@BouweCeunen
Copy link

I have this issue when there are 'completed' pods in my namespace. When I execute kubectl delete pods --field-selector=status.phase=Succeeded --all-namespaces, everything is ok.

@floreks
Copy link
Member

floreks commented Sep 5, 2019

@BskyRui what part of the sentence "Metrics support is part of v2 beta" is not clear? It will not work with v1. Also, there are still some issues related to the graphs itself: https://github.com/kubernetes/dashboard/milestone/1

@HelloMyDevWorld
Copy link

kubeadm v1.16.2 is there any idea how to run dashboard there ?

@oscarlofwenhamn
Copy link

@patsadow2 We've gotten the v2 beta dashboard running easily in our 1.16.2 cluster, using the manifest provided here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.