Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deferContainers - Pod Termination Semantics #256

Closed
dhilipkumars opened this issue Apr 22, 2017 · 13 comments
Closed

deferContainers - Pod Termination Semantics #256

dhilipkumars opened this issue Apr 22, 2017 · 13 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@dhilipkumars
Copy link

dhilipkumars commented Apr 22, 2017

Feature Description

  • One-line feature description (can be used as a release note): Pod Termination Semantics
  • Primary contact (assignee): @dhilipkumars
  • Responsible SIGs: @kubernetes/sig-apps-feature-requests @kubernetes/sig-node-feature-requests
  • Design proposal link (community repo): design-proposal
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @smarterclayton @erictune
  • Approver (likely from SIG/area to which feature belongs): @dchen1107
  • Feature target (which target equals to which milestone):
    • Alpha release target (1..7) minimal viable implementation of design and API (api) finished.
@dhilipkumars dhilipkumars changed the title deferContainers deferContainers - Pod Termination Semantics Apr 22, 2017
@dhilipkumars
Copy link
Author

dhilipkumars commented Apr 22, 2017

could someone add sig-apps and sig-nodes to this feature please.

@ghost ghost assigned dhilipkumars Apr 24, 2017
@ghost ghost added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 24, 2017
@ghost ghost added this to the v1.7 milestone Apr 24, 2017
@smarterclayton smarterclayton added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Apr 25, 2017
@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 3, 2017
@idvoretskyi
Copy link
Member

@dhilipkumars I've updated the feature description to fit the new template. Please, fill the empty fields in the new template (their actual state was unclear).

@calebamiles
Copy link
Contributor

@dchen1107, @derekwaynecarr I believe SIG Node still hasn't approved the design proposal yet. Should we move this issue out of the milestone?

cc: @idvoretskyi, @kubernetes/kubernetes-release-managers

@dhilipkumars
Copy link
Author

@calebamiles could we wait for a few more days, sig-node mentioned they would look at the proposal and give feedback this week. Plus we have started implementation already.

@dhilipkumars
Copy link
Author

It is important for our stateful application support in kubernetes.

@smarterclayton
Copy link
Contributor

We haven't reached consensus yet on whether this feature is appropriate for kubernetes, and design criteria is pretty involved. Given the history of how much work is involved, I don't see any way that this will have sufficient review to make 1.7. It would be better to take this out of 1.7 and propose it for 1.8 once there is design consensus on whether we want to support defer containers at all.

@idvoretskyi
Copy link
Member

cc @kubernetes/sig-node-feature-requests @kubernetes/sig-apps-feature-requests please comment on above.

@0xmichalis
Copy link

Agreed about moving this out of 1.7 - it's unlike that there is enough review bandwidth at this point

@yujuhong
Copy link
Contributor

yujuhong commented May 18, 2017

AFAIK, this feature wasn't included in the sig-node 1.7 roadmap, and the design still needs more review time. +1 for removing the 1.7 milestone.

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.7 May 18, 2017
@idvoretskyi
Copy link
Member

Updated, thanks.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

8 participants