Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy, automated upgrades with the kubeadm upgrade command #296

Closed
lukemarsden opened this issue May 4, 2017 · 34 comments
Closed

Easy, automated upgrades with the kubeadm upgrade command #296

lukemarsden opened this issue May 4, 2017 · 34 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@lukemarsden
Copy link
Contributor

lukemarsden commented May 4, 2017

Feature Description

@calebamiles calebamiles added this to the v1.7 milestone May 4, 2017
@calebamiles calebamiles added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 4, 2017
@idvoretskyi
Copy link
Member

@lukemarsden the feature freeze for 1.7 has already gone (on Monday, May 1).

@lukemarsden
Copy link
Contributor Author

@idvoretskyi yes, sorry – I've been slammed after DockerCon. I've been chatting to @calebamiles who said it might be possible to make an exception for this, please 🙏

@calebamiles
Copy link
Contributor

I think this work was already scheduled by the SIG, @idvoretskyi the issue was simply filed late which I don't think is a huge deal.

@calebamiles calebamiles added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 4, 2017
@luxas
Copy link
Member

luxas commented May 4, 2017

Yeah, this has been planned for a while, thanks @calebamiles!

@idvoretskyi
Copy link
Member

@lukemarsden @luxas sounds good to me, thanks.

@lukemarsden
Copy link
Contributor Author

lukemarsden commented May 23, 2017

Making a call on this – we're not going to make it for 1.7. Let's bump this to 1.8. Sorry.

cc @idvoretskyi

@timothysc
Copy link
Member

@lukemarsden is there a WIP fork or issue on this somewhere? Just wondering what the current state is.

@timothysc timothysc modified the milestones: next-milestone, v1.7 May 23, 2017
@lukemarsden
Copy link
Contributor Author

@timothysc nope, no code yet.

@luxas
Copy link
Member

luxas commented Jul 5, 2017

For subscribers of this thread, I've now written up kind of a new proposal for how to achieve this. see here: https://docs.google.com/document/d/1PRrC2tvB-p7sotIA5rnHy5WAOGdJJOIXPPv23hUFGrY

Feedback welcome, coding is expected to start next week-ish.

@luxas luxas modified the milestones: 1.8, next-milestone Jul 6, 2017
@luxas luxas added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jul 19, 2017
@luxas
Copy link
Member

luxas commented Jul 19, 2017

This will be beta in v1.8, our alpha was the kubeadm v1.6-v1.7 upgrade route: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm-upgrade-1-7/

The upgrades proposal in markdown format: kubernetes/community#825

I also updated the first comment to correctly reflect the status of this feature.

@justaugustus
Copy link
Member

@timothysc @luxas
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@luxas
Copy link
Member

luxas commented May 11, 2018

@justaugustus this feature won't move to GA yet, we're improving it incrementally in the beta state.

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 11, 2018
@luxas luxas removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 11, 2018
@justaugustus
Copy link
Member

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 1, 2018
@justaugustus justaugustus removed this from the v1.9 milestone Jul 1, 2018
@luxas
Copy link
Member

luxas commented Jul 30, 2018

This will be graduated at the same time kubeadm itself goes GA: #11

@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus
Copy link
Member

/kind feature
/stage stable

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 31, 2018
@justaugustus justaugustus added this to the v1.12 milestone Jul 31, 2018
@justaugustus
Copy link
Member

Tracking as GA for 1.12

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 31, 2018
@zparnold
Copy link
Member

Hey there! @lukemarsden I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus
Copy link
Member

@lukemarsden, @luxas @timothysc --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@neolit123
Copy link
Member

for this one, upgrades are already useful and the docs are in place for 1.11:
https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-upgrade/
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-11/

there are still some question marks in terms of implementation and we have some tracking issues in k/kubeadm.

the KEP for this seems to be still in flight:
kubernetes/community#825

also, we don't have placeholder docs for 1.12, yet.

@timothysc timothysc modified the milestones: v1.12, v1.13 Sep 7, 2018
@timothysc
Copy link
Member

We're aiming for GA in 1.13 at this point.

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 7, 2018
@justaugustus
Copy link
Member

Thanks for the update, @timothysc !

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2018
@kacole2
Copy link

kacole2 commented Oct 18, 2018

@timothysc i'm curious if this should just be rolled into #11 and tracked there since it's all going GA at the same time. Or is it better to track kubeadm features separately? Are kubeadm upgrades still targeting 1.13?

@timothysc
Copy link
Member

Closing in favor of #11 .

We are in the final stages now of moving towards GA.

@kacole2 kacole2 removed this from the v1.13 milestone Oct 30, 2018
@kacole2 kacole2 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests