Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl binary plugins #371

Closed
fabianofranz opened this issue Jul 31, 2017 · 17 comments
Closed

kubectl binary plugins #371

fabianofranz opened this issue Jul 31, 2017 · 17 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@fabianofranz
Copy link
Contributor

fabianofranz commented Jul 31, 2017

Feature Description

  • One-line feature description (can be used as a release note): Plugins to allow extending the set of commands provided by the main kubectl binary.
  • Primary contact (assignee): @fabianofranz
  • Responsible SIGs: @kubernetes/sig-cli-feature-requests
  • Design proposal link (community repo):
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @monopole @pwittrock @adohe @droot @deads2k @soltysh @smarterclayton
  • Approver (likely from SIG/area to which feature belongs): @fabianofranz
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.8)
    • Beta release target (1.9)
    • Stable release target (1.10)
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 31, 2017
@fabianofranz
Copy link
Contributor Author

Initial support already added in 1.7 by kubernetes/kubernetes#37499, and a couple subsequent PR's that fixed issues and added other minor features.

@fabianofranz
Copy link
Contributor Author

/sig cli

@fabianofranz fabianofranz added this to the 1.8 milestone Jul 31, 2017
@fabianofranz fabianofranz added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 31, 2017
@fabianofranz
Copy link
Contributor Author

Discussed and agreed by the SIG-CLI group on July 19.

@pwittrock
Copy link
Member

@fabianofranz Is there anything worth adding to the release notes for 1.8 on this?

@fabianofranz
Copy link
Contributor Author

@pwittrock not for 1.8 since the most important things already got release notes in prior releases. We'll likely have more notes for upcoming releases, while plugins progresses from alpha.

@idvoretskyi
Copy link
Member

@fabianofranz should this feature still be on track for 1.8?

@fabianofranz
Copy link
Contributor Author

@idvoretskyi yes, it's still on track and all code PR's merged before code freeze. I just opened a docs PR.

@pwittrock
Copy link
Member

@fabianofranz Excellent. Once those are merged should we mark this as closed, and open a new one for 1.9?

@fabianofranz
Copy link
Contributor Author

Docs PR merged for this feature.

@idvoretskyi what's the process here, do we just close this issue since it's all done (PR merged before code freeze, docs merged, release notes updated)?

@idvoretskyi
Copy link
Member

@fabianofranz if you are expecting to make a progress with the feature for the next releases, please keep it open.

Only the milestone (and stage/* label) should be updated after the next release train will go.

@fabianofranz
Copy link
Contributor Author

@idvoretskyi thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2018
@tamalsaha
Copy link
Member

@fabianofranz @pwittrock what are the plans for graduating kubectl plugin to beta? Is there an issue to follow?

@fabiand
Copy link

fabiand commented Feb 19, 2018

One thing I noticed creating a plugin for KubeVirt is that it would be handy to get the cluster credentials and additional stuff (i.e. cluster api sevrer uri) passed as env variables. Is this being done today?

@deads2k
Copy link
Contributor

deads2k commented Feb 22, 2018

@fabianofranz @pwittrock what are the plans for graduating kubectl plugin to beta? Is there an issue to follow?

@soltysh @adohe it may be worth considering experiences here. I've seen pulls going by that make the registration process look a little weird. I suspect the attempt was to "make it easy", but may have accidentally produces additional, unnecessary work for implementors

@soltysh soltysh self-assigned this Mar 8, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

9 participants