Provide environment variables expansion in sub path mount

[kevtaylor]

Feature Description

• One-line feature description (can be used as a release note): Provide environment variables expansion in sub path mount
• Primary contact (assignee): @kevtaylor
• Responsible SIGs: kubernetes/sig-storage
• Design proposal link (community repo):
  Downward API support in volume subPath kubernetes#48677
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20181029-volume-subpath-env-expansion.md
• Link to e2e and/or unit tests:
  Dynamic env in subpath - Fixes Issue 48677 kubernetes#49388
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @msau42 @jsafrane
• Approver (likely from SIG/area to which feature belongs): @msau42
• Feature target (which target equals to which milestone):
  • Alpha release target (1.11)
  • Beta release target (1.15)
  • Stable release target (1.17)

[msau42]

Assignee should be @kevtaylor ;-)

[kevtaylor]

Related to this issue kubernetes/kubernetes#48677 not the one above

[jsafrane]

"Design proposal link" leads to "taint node 'shutdown' condition"

[kevtaylor]

@jsafrane Sorry, I corrected it in the comment above - but I didn't know how to edit the original

[kevtaylor]

@jsafrane Actually - forget that - I just did it

[kevtaylor]

@jsafrane I also update the assignee as per @msau42 comments

[justaugustus]

@kevtaylor
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

• Description
• Milestone
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

/assign @kevtaylor

cc @idvoretskyi

[kevtaylor]

/sig storage

[kevtaylor]

/kind feature

[justaugustus]

Thanks for the update, @kevtaylor!

[justaugustus]

@kevtaylor --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

[kevtaylor]

@justaugustus I didn't have edit rights - I have requested them

[kevtaylor]

@justaugustus Should be up to date now.

[justaugustus]

@kevtaylor yup, just saw it. Thanks for the update!

[kevtaylor]

@justaugustus Hi. I wanted to update the test status of the feature in the spreadsheet but it no longer seems to allow me to edit it. Is that intentional?

[justaugustus]

@kevtaylor definitely intentional. We locked up permissions on the sheet, but feel free to drop comments in the relevant cells, tag me, and I'll get it updated.

[kevtaylor]

@justaugustus Thanks, I saw that you can add a comment, so I have added one.

[kacole2]

@kevtaylor This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12 as mentioned in your original post.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[kevtaylor]

@kacole2 The intention was to do a simple migration to beta, but this has been blocked by @liggitt and @thockin who want to revamp the api instead so I don't know what the future plans are. Discussion is here kubernetes/kubernetes#65769

[kevtaylor]

@palnabarun yes this is graduating in 1.17

[kevtaylor]

@palnabarun
KEP Graduation update: #1255
Code PR: kubernetes/kubernetes#82578
Docs PR: kubernetes/website#16547

[palnabarun]

@kevtaylor Awesome. 🎉 Thank you for the updates. I have updated the tracking sheet with the details.

[palnabarun]

/milestone v1.17

[irvifa]

Hello @kevtaylor I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[kevtaylor]

@irvifa Docs PR: kubernetes/website#16547

[irvifa]

Awesome... Thanks a lot @kevtaylor !

[palnabarun]

Hi @kevtaylor

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#82578 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

[kevtaylor]

@palnabarun No further PRs other than those already mentioned here

[palnabarun]

@kevtaylor Thank you for the updates! :)

[palnabarun]

Hi @kevtaylor , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[kevtaylor]

@palnabarun the issue that was added is not an essential enhancement but merely to switch the tests to conformance. The original PR is not blocked by this and is merged. If @msau42 approves today, this new test suite can also go in

[palnabarun]

@kevtaylor

Thank you for the updates. In that case, shall I remove kubernetes/kubernetes#85128 from 1.17 tracking due to its non-blocking nature and flip back the status to Tracked?

[kevtaylor]

@palnabarun I would do that in case 85128 doesnt get approved in time. Sorry to confuse everything! If it gets merged today we can put it in the release if that's not going to cause pain.

[palnabarun]

@kevtaylor Now worries! That sounds good to me.

Do reach out in case you have any queries. 😃

[kevtaylor]

@palnabarun it appears that the ga feature has been removed from the milestone in the spreadsheet tracker.

[guineveresaenger]

We're putting it back in, sorry for all the confusion!

[jeremyrickard]

Hey @kevtaylor , Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

[kevtaylor]

@jeremyrickard Hi. Thanks for that. I'll sort the KEP out and ping back when I've submitted it.

[justaugustus]

@kevtaylor -- You can feel free to come back and /close this once the KEP has been flipped to implemented.