kubeadm: graduate the kubeadm configuration #970

neolit123 · 2019-04-17T10:38:42Z

Enhancement Description

One-line enhancement description (can be used as a release note):

Iterate on the kubeadm configuration (API) until it graduates to GA

Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR) https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config
Primary contact (assignee): @neolit123
Responsible SIGs: Cluster-Lifecycle
Enhancement target (which target equals to which milestone):
- Alpha release target PAST
- Beta release target 1.22 (v1beta3)
- Stable release target TODO

1.15

for the 1.15 cycle we want to upgrade the config type from v1beta1 to v1beta2.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1439

1.22

for the 1.22 cycle we want to upgrade the config type from v1beta2 to v1beta3.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1796

KEP updates:

sig-cluster-lifecycle: update the kubeadm config KEP for 1.22 #2627

k8s-ci-robot · 2019-04-17T10:38:47Z

@neolit123: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR
specifying the label manually: /sig <group-name>
e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rosti · 2019-04-17T11:23:19Z

/assign

rosti · 2019-04-17T11:23:31Z

Thanks for creating the issue @neolit123 !

neolit123 · 2019-04-18T11:07:12Z

@rosti
updated the description and title.

craiglpeters · 2019-04-29T20:29:07Z

@fabriziopandini and @luxas, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

neolit123 · 2019-04-29T20:54:30Z

@craiglpeters thanks for the heads up. done:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md

christianh814 · 2019-05-13T17:39:05Z

Hey @neolit123 and @rosti I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

neolit123 · 2019-05-13T20:04:02Z

hi @christianh814
this work will require minor updates on already existing links to the godocs documentation of the kubeadm API. we are going to have the PRs up before the 31st.

thanks for the heads up.

craiglpeters · 2019-05-29T01:04:29Z

Hi @rosti. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

makoscafee · 2019-05-29T06:57:08Z

Hi, @neolit123 I am docs Lead.
Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must have placeholder docs PRs open.
Just friendly following up on this. Thanks

rosti · 2019-05-29T08:28:03Z

Thanks for the reminder @makoscafee and @craiglpeters !

rosti · 2019-05-29T11:15:30Z

@craiglpeters
kubernetes/kubernetes#77739
kubernetes/kubernetes#78403

@makoscafee
kubernetes/website#14607

Those are the PRs.

jrsapi · 2021-05-09T23:49:48Z

Greetings @neolit123!
1.22 Enhancement shadow checking in. The Enhancement freeze is this Thursday, 5/13. In reviewing your KEP, one item needing attention before the freeze:

(PRR) Production readiness review needs to be approved. #prod-readiness channel on K8s slack can assist.

Thanks!

neolit123 · 2021-05-10T14:24:57Z

@jrsapi hello,
the kubeadm API predates the PRR process. it was never done for it and is arguably not needed.
based on recent discussions, PRR was partially a no-op for another kubeadm KEP:
#2620 (comment)

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

jrsapi · 2021-05-10T20:18:18Z

Thanks for the link to the comment. I'll move the to "Tracked" in the Enhancement spreadsheet.

ehashman · 2021-05-11T18:39:07Z

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

This is already true; PRR is optional for out-of-tree components. We discussed this at the last PRR meeting.

PI-Victor · 2021-05-18T10:49:30Z

Hello @neolit123 👋, 1.22 Docs release lead here.

This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Can you confirm that kubernetes/website#28010 is related to this KEP?
If there are any other changes that need docs updates, please open a PR against k/website dev-1.22 branch before Fri July 9, 11:59 PM PDT (docs placeholder PR deadline).
thank you

neolit123 · 2021-05-18T11:43:22Z

That PR is not related. We have enough time to sent the website PRs for this work. Thank you for the reminder.

jrsapi · 2021-06-24T03:16:49Z

Greetings @neolit123,
Enhancement team shadow checking in with a few updates. Currently, we are tracking this PR for the 1.22 milestone. Are there any other PR's that are not linked that should be tracked?

A reminder about code freeze which is July 8th, 2021 11:59 PST. All implementation PR's must be code complete and merged before the deadline. Thanks for your partnership.

neolit123 · 2021-06-24T13:00:43Z

Hi, we merged a lot of PRs and some are still pending review. A detailed list can be seen here: kubernetes/kubeadm#1796 Thanks for the reminder. EDIT: corrected wrong sub comment on issue.

neolit123 · 2021-07-06T21:11:34Z

@jrsapi
we consider the work for this "feature" in 1.22 completed (minus docs).
the "feature" remains in "beta".

the full list of merged PRs is here:
kubernetes/kubeadm#1796

e2e tests are updated:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm

docs PR is pending /lgtm:
kubernetes/website#28360

k8s-triage-robot · 2021-11-17T21:40:08Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2021-12-17T22:37:23Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

neolit123 · 2021-12-18T00:08:29Z

/remove-lifecycle rotten

k8s-triage-robot · 2022-03-18T00:40:10Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

rhockenbury · 2022-10-01T02:03:09Z

/milestone clear

pacoxu · 2023-03-14T07:55:48Z

v1beta4 candidate

k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 17, 2019

neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2019

neolit123 added this to the v1.15 milestone Apr 17, 2019

rosti mentioned this issue Apr 17, 2019

v1beta2 config kubernetes/kubeadm#1439

Closed

4 tasks

neolit123 added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Apr 17, 2019

k8s-ci-robot assigned rosti Apr 17, 2019

kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 17, 2019

rosti mentioned this issue Apr 17, 2019

kubeadm: Introduce v1beta2 config kubernetes/kubernetes#76710

Merged

neolit123 changed the title ~~kubeadm: upgrade the configuration to v1beta2~~ kubeadm: graduate the kubeadm configuration to GA Apr 18, 2019

neolit123 changed the title ~~kubeadm: graduate the kubeadm configuration to GA~~ kubeadm: graduate the kubeadm configuration Apr 18, 2019

rosti mentioned this issue Apr 24, 2019

kubeadm: Add certificateKey field to v1beta2 config kubernetes/kubernetes#77012

Merged

neolit123 mentioned this issue Apr 29, 2019

kubeadm: add implementable status to 0023-kubeadm-config.md #1017

Merged

rosti mentioned this issue May 2, 2019

kubeadm: Fix omitempty in v1beta2 kubernetes/kubernetes#77345

Merged

rosti mentioned this issue May 10, 2019

kubeadm: Remove ClusterConfiguration from InitConfiguration in v1beta2 kubernetes/kubernetes#77739

Merged

rosti mentioned this issue May 27, 2019

kubeadm: Update v1beta2 doc.go kubernetes/kubernetes#78403

Merged

rosti mentioned this issue May 29, 2019

kubeadm: Document new v1beta2 config format kubernetes/website#14607

Merged

salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021

neolit123 mentioned this issue Sep 9, 2021

KEP-1739: retro-update the customization with patches to Beta #2967

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 18, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2022

neolit123 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2022

neolit123 mentioned this issue Sep 29, 2022

ResetConfiguration and UpgradeConfiguration API definition #3567

Closed

4 tasks

k8s-ci-robot removed this from the v1.22 milestone Oct 1, 2022

pacoxu mentioned this issue Mar 22, 2023

Support custom env in kubeadm ControlPlaneComponent kubernetes/kubeadm#2845

Closed

Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023

chendave mentioned this issue Jun 9, 2023

release v1beta4 kubernetes/kubeadm#2890

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: graduate the kubeadm configuration #970

kubeadm: graduate the kubeadm configuration #970

neolit123 commented Apr 17, 2019 •

edited

Loading

k8s-ci-robot commented Apr 17, 2019

rosti commented Apr 17, 2019

rosti commented Apr 17, 2019

neolit123 commented Apr 18, 2019

craiglpeters commented Apr 29, 2019

neolit123 commented Apr 29, 2019

christianh814 commented May 13, 2019

neolit123 commented May 13, 2019

craiglpeters commented May 29, 2019

makoscafee commented May 29, 2019

rosti commented May 29, 2019 •

edited

Loading

rosti commented May 29, 2019

jrsapi commented May 9, 2021 •

edited

Loading

neolit123 commented May 10, 2021

jrsapi commented May 10, 2021 •

edited

Loading

ehashman commented May 11, 2021

PI-Victor commented May 18, 2021

neolit123 commented May 18, 2021 via email

jrsapi commented Jun 24, 2021

neolit123 commented Jun 24, 2021 via email •

edited

Loading

neolit123 commented Jul 6, 2021

k8s-triage-robot commented Nov 17, 2021

k8s-triage-robot commented Dec 17, 2021

neolit123 commented Dec 18, 2021

k8s-triage-robot commented Mar 18, 2022

rhockenbury commented Oct 1, 2022

pacoxu commented Mar 14, 2023 •

edited

Loading

kubeadm: graduate the kubeadm configuration #970

kubeadm: graduate the kubeadm configuration #970

Comments

neolit123 commented Apr 17, 2019 • edited Loading

Enhancement Description

k8s-ci-robot commented Apr 17, 2019

rosti commented Apr 17, 2019

rosti commented Apr 17, 2019

neolit123 commented Apr 18, 2019

craiglpeters commented Apr 29, 2019

neolit123 commented Apr 29, 2019

christianh814 commented May 13, 2019

neolit123 commented May 13, 2019

craiglpeters commented May 29, 2019

makoscafee commented May 29, 2019

rosti commented May 29, 2019 • edited Loading

rosti commented May 29, 2019

jrsapi commented May 9, 2021 • edited Loading

neolit123 commented May 10, 2021

jrsapi commented May 10, 2021 • edited Loading

ehashman commented May 11, 2021

PI-Victor commented May 18, 2021

neolit123 commented May 18, 2021 via email

jrsapi commented Jun 24, 2021

neolit123 commented Jun 24, 2021 via email • edited Loading

neolit123 commented Jul 6, 2021

k8s-triage-robot commented Nov 17, 2021

k8s-triage-robot commented Dec 17, 2021

neolit123 commented Dec 18, 2021

k8s-triage-robot commented Mar 18, 2022

rhockenbury commented Oct 1, 2022

pacoxu commented Mar 14, 2023 • edited Loading

neolit123 commented Apr 17, 2019 •

edited

Loading

rosti commented May 29, 2019 •

edited

Loading

jrsapi commented May 9, 2021 •

edited

Loading

jrsapi commented May 10, 2021 •

edited

Loading

neolit123 commented Jun 24, 2021 via email •

edited

Loading

pacoxu commented Mar 14, 2023 •

edited

Loading