Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Cluster Bootstrap/Discovery with Kubenetes Core #130

Closed
jbeda opened this issue Oct 11, 2016 · 57 comments
Closed

Integrate Cluster Bootstrap/Discovery with Kubenetes Core #130

jbeda opened this issue Oct 11, 2016 · 57 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@jbeda
Copy link
Contributor

jbeda commented Oct 11, 2016

Feature Description

  • One-line feature description (can be used as a release note): Add a new authentication and verification mechanism called Bootstrap Tokens to use to easily add new members to a cluster
  • Primary contact (assignee): @luxas @jbeda
  • Responsible SIGs: sig/cluster-lifecycle, sig/auth
  • Design proposal link (community repo): Update the token discovery proposal community#628
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @mikedanese @liggitt @ericchiang
  • Approver (likely from SIG/area to which feature belongs): @mikedanese @liggitt @ericchiang
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): v1.6
    • Beta release target (x.y): v1.8
    • Stable release target (x.y): TODO
@jbeda jbeda added this to the v1.5 milestone Oct 11, 2016
@idvoretskyi idvoretskyi added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 12, 2016
@idvoretskyi
Copy link
Member

@jbeda I noticed that the feature has been opened after the agreed submission deadline (Oct 10). Is there any reason why this feature has to be added to 1.5 milestone?

@jbeda
Copy link
Contributor Author

jbeda commented Oct 12, 2016

@idvoretskyi I screwed up and I apologize. We were tracking all of the work in the the lifecycle SIG and met on Tuesday morning. Missed it by one day. Hopefully this isn't a blocker?

@mikedanese
Copy link
Member

mikedanese commented Oct 12, 2016

meta: I don't understand the 1.5 milestone deadline. If a feature get's dreamed up after the deadline, alpha implemented and merged before we cut 1.5 is it still a feature? I see the purpose of this repo as providing visibility to progress on large features. I don't see any purpose to a submission deadline. There's also no documentation of a deadline in this repo (when or why).

@idvoretskyi
Copy link
Member

@mikedanese the purpose of the repo - is providing visibility and tracking on the product features, you are right. At the same time, during the release development process, we'd like to see the actual picture of the features that are going to be added to the product.
Feature submission deadline - is not the deadline for developing the feature; it's a deadline for declaring your desire to develop some functionality that you'd like to see in the released product. We are expecting from all the contributors to follow the release roadmap carefully to avoid unnecessary planning chaos.
PS. Thank you for mentioning the reflecting the deadline in the documentation - I've submitted a PR to add it to the release roadmap #133.

@idvoretskyi
Copy link
Member

@jbeda as we have already agreed in the mailing thread [0], this is not a blocker.
0. https://groups.google.com/d/msg/kubernetes-sig-cluster-lifecycle/AyNEsX2lJnU/Hv0SYJFJEgAJ

@jbeda jbeda added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 13, 2016
@jbeda
Copy link
Contributor Author

jbeda commented Oct 13, 2016

cc @kubernetes/sig-cluster-lifecycle

@luxas
Copy link
Member

luxas commented Nov 20, 2016

Hmm, this didn't make v1.5, did it?

@idvoretskyi
Copy link
Member

@jbeda @luxas any final agreement on this?

@jbeda
Copy link
Contributor Author

jbeda commented Nov 22, 2016

Pushing to 1.6

@idvoretskyi idvoretskyi modified the milestones: v1.6, v1.5 Nov 24, 2016
@idvoretskyi
Copy link
Member

@jbeda can you confirm that this feature targets alpha for 1.6?

@apsinha
Copy link

apsinha commented Feb 3, 2017

Should we add the alpha-in -1.6 label to this?

@idvoretskyi
Copy link
Member

@apsinha I think so, updated.

@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 6, 2017
@luxas
Copy link
Member

luxas commented Feb 6, 2017

I'm not sure whether we'll call it alpha or beta, it might be beta as well, if we count the kube-discovery method currently used in kubeadm as the alpha implementation

cc @jbeda @mikedanese

@idvoretskyi
Copy link
Member

@luxas marked as alpha following the previous discussions. Let's discuss the appropriate feature stage if there are other suggestions.

@roberthbailey
Copy link
Contributor

I believe @mikedanese labeled the api objects as beta for 1.6.

@luxas luxas removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 17, 2018
@justaugustus justaugustus removed this from the v1.9 milestone Jul 1, 2018
@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added kind/feature Categorizes issue or PR as related to a new feature. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 4, 2018
@kacole2
Copy link

kacole2 commented Oct 8, 2018

Hi
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:

  • Docs (open placeholder PRs): 11/8
  • Code Slush: 11/9
  • Code Freeze Begins: 11/15
  • Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2019
@bgrant0607 bgrant0607 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@roberthbailey
Copy link
Contributor

/remove-lifecycle stale
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2019
@roberthbailey
Copy link
Contributor

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2019
@fejta-bot
Copy link

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 15, 2019
@claurence
Copy link

@luxas Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@kacole2
Copy link

kacole2 commented Apr 12, 2019

Hello @luxas, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. This will also require a KEP to be included. If this feature has been abandoned please let us know.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2
Copy link

kacole2 commented Jul 9, 2019

Hi @luxas @roberthbailey , I'm the 1.16 Enhancement Lead/Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@jeremyrickard
Copy link
Contributor

Hey there @roberthbailey @luxas -- 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll also need to convert the design proposal into a KEP. To be accepted in the release, all enhancements MUST have a KEP, the KEP MUST be merged, in an implementable state, and have both graduation criteria/test plan.

Thanks!

@roberthbailey
Copy link
Contributor

Please check with @timothysc / @justinsb.

@jeremyrickard
Copy link
Contributor

Thanks @roberthbailey! @timothysc @justinsb ping on this? Enhancement freeze will be Tuesday, October 15, EOD PST. Thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@neolit123
Copy link
Member

/close

after the discussion in the kubeadm office hours with @timothysc we decided to close this ticket as out of date.

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closing this issue.

In response to this:

/close

after the discussion in the kubeadm office hours with @timothysc we decided to close this ticket as out of date.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
akhilerm pushed a commit to akhilerm/apimachinery that referenced this issue Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 38252, 41122, 36101, 41017, 41264)

BootstrapSigner and TokenCleaner controllers

This is part of kubernetes/enhancements#130 and is an implementation of kubernetes/community#189.

Work that needs to be done yet in this PR:
* [ ] ~~e2e tests~~ Will come in new PR.
* [x] flag to disable this by default

```release-note
Native support for token based bootstrap flow.  This includes signing a well known ConfigMap in the `kube-public` namespace and cleaning out expired tokens.
```

@kubernetes/sig-cluster-lifecycle @dgoodwin @roberthbailey @mikedanese

Kubernetes-commit: 866aa735912e548a73ff54c4b6c9b338adfa19e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests