Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU Manager for pod cpuset assignment #375

Closed
sjenning opened this issue Aug 1, 2017 · 19 comments
Closed

Add CPU Manager for pod cpuset assignment #375

sjenning opened this issue Aug 1, 2017 · 19 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@sjenning
Copy link
Contributor

sjenning commented Aug 1, 2017

Feature Description

  • One-line feature description (can be used as a release note): add CPU Manager for pod cpuset assignment based on resource/QoS attributes
  • Primary contact (assignee): @sjenning, @ConnorDoyle
  • Responsible SIGs: sig-node
  • Design proposal link (community repo): Add CPU manager proposal. community#654
  • Reviewer(s) - (for LGTM) @derekwaynecarr @vishh
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone): alpha 1.8

Add UpdateContainerResources method to CRI:
kubernetes/kubernetes#46105

Primary feature PR:
kubernetes/kubernetes#49186

@jdumars
Copy link
Member

jdumars commented Aug 1, 2017

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 1, 2017
@ConnorDoyle
Copy link
Contributor

@dchen1107 or @vishh -- could one of you add the v1.8 milestone?

@ConnorDoyle
Copy link
Contributor

Also the stage/alpha label please.

@vishh vishh added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Aug 1, 2017
@vishh vishh added this to the 1.8 milestone Aug 1, 2017
@ConnorDoyle
Copy link
Contributor

/assign @sjenning
/assign @ConnorDoyle

@idvoretskyi
Copy link
Member

@sjenning @kubernetes/sig-cluster-lifecycle-feature-requests any updates for 1.8? Is this feature still on track for the release?

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 5, 2017
@ConnorDoyle
Copy link
Contributor

Yes, the alpha version of the feature merged over the weekend, examples and node e2e are in review.

@roberthbailey roberthbailey removed the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 27, 2017
@ConnorDoyle
Copy link
Contributor

We are targeting v1.9 to graduate this feature from alpha to beta.

@adohe-zz
Copy link

@ConnorDoyle as what we talk on Slack, is there anything I can help?

@pires
Copy link

pires commented Jan 31, 2018

Was this in fact graduated to beta in 1.9?

@idvoretskyi
Copy link
Member

@pires no, this feature hasn't been announced as beta in 1.9.

@justaugustus
Copy link
Member

@ConnorDoyle @sjenning
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@justaugustus justaugustus removed this from the v1.8 milestone Jul 1, 2018
@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 4, 2018
@kacole2
Copy link

kacole2 commented Oct 8, 2018

Hi
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:

  • Docs (open placeholder PRs): 11/8
  • Code Slush: 11/9
  • Code Freeze Begins: 11/15
  • Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2019
@mrbobbytables
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2019
@claurence
Copy link

@sjenning, @ConnorDoyle Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@sjenning
Copy link
Contributor Author

Didn't realize this was still hanging around. This went alpha in 1.9, which is what this issue is tracking. We can open a new issue to track beta promotion IIUC.

@sjenning
Copy link
Contributor Author

I'm losing it. This went beta a long time ago kubernetes/kubernetes#55977

@ffromani
Copy link
Contributor

ffromani commented Jun 7, 2022

I'm working to graduate this feature to GA in 1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests