Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isControllerTagValid or make it optional #11708

Closed
tamalsaha opened this issue Jul 31, 2024 · 2 comments · Fixed by #11710
Closed

Remove isControllerTagValid or make it optional #11708

tamalsaha opened this issue Jul 31, 2024 · 2 comments · Fixed by #11710
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tamalsaha
Copy link
Member

tamalsaha commented Jul 31, 2024 •
edited
Loading

I am trying to enlist a product on Google cloud marketplace. Gcp MP requires that all images and tag be configurable. My product includes ingress-nginx . But it won't run because the tag from GCP MP does not meet the requirements of isControllerTagValid. Please either remove this check or give us a way to disable this check.

https://github.com/kubernetes/ingress-nginx/blob/helm-chart-4.11.1/charts/ingress-nginx/templates/_helpers.tpl#L248-L254
@tamalsaha tamalsaha added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jul 31, 2024
@Gacko Gacko mentioned this issue Jul 31, 2024
Merged
10 tasks
@Gacko
Copy link
Member

Gacko commented Jul 31, 2024

Here we go: #11710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
[SIG Network] Ingress NGINX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chart: Remove isControllerTagValid.
3 participants
@tamalsaha @Gacko @k8s-ci-robot