Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nginx] Allow custom configuration at multiple levels #1324

Closed
foxylion opened this issue Sep 8, 2017 · 3 comments · Fixed by #1454
Closed

[nginx] Allow custom configuration at multiple levels #1324

foxylion opened this issue Sep 8, 2017 · 3 comments · Fixed by #1454
Labels

Comments

@foxylion
Copy link
Contributor

foxylion commented Sep 8, 2017

I think it would be great to allow customized configuration to be injected into the template without the need to modify it.

In the config map we could add the following options:
custom-http-configuration: A snippet which is added at the end of http { ... }
custom-server-configuration: A snippet which is added at the end of every server { ... } for ingress configurations
custom-location-configuration: A snippet which is added at the end of the location { ... } inside the server config

This would allow to solve most customization without modifying the template itself.

Additionally it could be allowed to use the configuration options for server and location also an ingress annitations. This could enable customized configuration for a specific ingress rule.

@foxylion
Copy link
Contributor Author

foxylion commented Sep 9, 2017

@aledbf This is so far great, yes. But some things I've to configure for every ingress (e.g. proxy_pass_request_headers on; it would be nice if this is possible.
Because ingress configurations are written by all developers, ingress deployment is only done by the people administrating the cluster. And the developers should not necessarily need to care about things like this.

@aledbf
Copy link
Member

aledbf commented Sep 9, 2017

But some things I've to configure for every ingress (e.g. proxy_pass_request_headers on; it would be nice if this is possible.

The default for proxy_pass_request_headers is on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants