Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to switch off nginx access_log #234

Closed
aledbf opened this issue Feb 6, 2017 · 6 comments
Closed

Allow to switch off nginx access_log #234

aledbf opened this issue Feb 6, 2017 · 6 comments
Labels

Comments

@aledbf
Copy link
Member

aledbf commented Feb 6, 2017

No description provided.

@rikatz
Copy link
Contributor

rikatz commented Feb 8, 2017

@aledbf The idea for this is as ConfigMap (global), per server (annotation) or per location (I don't think Ingress Object support this)?

@aledbf
Copy link
Member Author

aledbf commented Feb 8, 2017

The idea for this is as ConfigMap (global),

To add the feature, later we can add an annotation to configure per ingress (per server)

@agustincastanio
Copy link

+1

@rikatz
Copy link
Contributor

rikatz commented Feb 9, 2017

@aledbf Was going to check this one, but found this:

https://github.com/kubernetes/ingress/blob/master/controllers/nginx/pkg/template/configmap.go#L32

I've checked that this directive is related to disabling logging to places like '/healthz', '/nginx_status' and so (when configured).

So, may I create a 'disable-access-log' configMap here? This is not related, right?

@aledbf
Copy link
Member Author

aledbf commented Feb 9, 2017

@rikatz this is different. The user wants to disable all the logging. The link allows to skip some urls from the logs (like health-checks)

So, may I create a 'disable-access-log' configMap here? This is not related, right?

👍

@rikatz
Copy link
Contributor

rikatz commented Feb 16, 2017

@aledbf Let's close this one 😄

@aledbf aledbf closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants