You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if they don't have spec.rule.HTTP. But this will probably require a change in createUpstreams because it does not return after creating an upstream based on ing.Spec.Backend if ing.Spec.Backend is not nil. It continues to iterate through ing.Spec.Rules[].HTTP.Paths to build upstreams based on ing.Spec.Rules[].HTTP.Paths[].Backend which will be nil after the normalization above. Currently it does not get hit because of
if rule.HTTP == nil {
continue
}
After normalization we would also have to change catch all server detection to rely on lack of host rather than HTTP
The text was updated successfully, but these errors were encountered:
ingress-nginx currently does not parse ingress manifests like following correctly:
For this the controller creates the server with default backend. The code responsible for this is at
ingress-nginx/internal/ingress/controller/controller.go
Line 405 in c4ba238
One possible fix would be to normalize ingresses at
ingress-nginx/internal/ingress/controller/store/store.go
Line 602 in c4ba238
createUpstreams
because it does not return after creating an upstream based oning.Spec.Backend
ifing.Spec.Backend
is notnil
. It continues to iterate throughing.Spec.Rules[].HTTP.Paths
to build upstreams based oning.Spec.Rules[].HTTP.Paths[].Backend
which will benil
after the normalization above. Currently it does not get hit because ofAfter normalization we would also have to change catch all server detection to rely on lack of
host
rather thanHTTP
The text was updated successfully, but these errors were encountered: