Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason to change the release tag scheme? #5454

Closed
jchauncey opened this issue Apr 27, 2020 · 6 comments
Closed

Any reason to change the release tag scheme? #5454

jchauncey opened this issue Apr 27, 2020 · 6 comments
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@jchauncey
Copy link

It went from nginx-<semver> to controller-<semver>. This broke some automation we have around rebuilding the project for internal releases so just want to make sure if this was intentional or an accident?

@jchauncey jchauncey added the kind/support Categorizes issue or PR as a support question. label Apr 27, 2020
@aledbf
Copy link
Member

aledbf commented Apr 27, 2020

@jchauncey apologies for the change. This is required due to the migration of the helm chart to this repository and the need to release both artifacts from this repository.
The name controller-<semver> is the new one to be used.

@jchauncey
Copy link
Author

Sounds good!

@mathieu-benoit
Copy link
Contributor

Just curious @aledbf, so moving forward, the associated helm chart won't be anymore here: https://github.com/helm/charts/tree/master/stable/nginx-ingress but will be here now: https://github.com/kubernetes/ingress-nginx/tree/master/charts/ingress-nginx, correct? So it won't appear anymore in https://hub.helm.sh/charts/stable/nginx-ingress moving forward?

@aledbf
Copy link
Member

aledbf commented Apr 29, 2020

the associated helm chart won't be anymore here: https://github.com/helm/charts/tree/master/stable/nginx-ingress but will be here now: https://github.com/kubernetes/ingress-nginx/tree/master/charts/ingress-nginx, correct?

Correct.

So it won't appear anymore in https://hub.helm.sh/charts/stable/nginx-ingress moving forward?

The stable repository is being deprecated. Please check https://github.com/helm/charts/issues/21103

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Apr 29, 2020

Go it, thanks!

The stable repository is being deprecated. Please check helm/charts#21103

Didn't know/notice that (but makes a lot of sense to track individually the helm chart release for example), thanks for the info!

@scottrigby
Copy link
Contributor

scottrigby commented Aug 21, 2020

PS @jchauncey @mathieu-benoit there's now a documented migration path from stable/nginx-ingress to ingress-nginx/ingress-nginx: #6038 Hope it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

No branches or pull requests

4 participants