Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy-real-ip-cidr should be a list like whitelist-source-range #692

Closed
damoon opened this issue May 8, 2017 · 0 comments · Fixed by #921
Closed

proxy-real-ip-cidr should be a list like whitelist-source-range #692

damoon opened this issue May 8, 2017 · 0 comments · Fixed by #921
Labels

Comments

@damoon
Copy link

damoon commented May 8, 2017

i would like to list trusted networks for forwarded-for headers. in my case cloudflares ips https://www.cloudflare.com/ips/.

the same methood of ,-seperation (in whitelist-source-range) could be used to list different (recursive) trusted network. https://github.com/kubernetes/ingress/blob/master/controllers/nginx/configuration.md#whitelist-source-range

the lines in the nginx template are https://github.com/kubernetes/ingress/blob/master/controllers/nginx/rootfs/etc/nginx/template/nginx.tmpl#L22 and https://github.com/kubernetes/ingress/blob/master/controllers/nginx/rootfs/etc/nginx/template/nginx.tmpl#L299

sorry, about my missing golang knowledge. i do not know what to do there to get the configmap and annotation data to the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants