Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few bugs in the nginx-ingress-controller Makefile #442

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Mar 14, 2017

  • make 'clean' use the new path to the built binary
  • make 'container' depend on 'build'

@aledbf

* make 'clean' use the new path to the built binary
* make 'container' depend on 'build'
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Mar 14, 2017
@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

@ixdy thanks!

@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

merging, no code changes.

@aledbf aledbf merged commit b7b6b90 into kubernetes:master Mar 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.147% when pulling 071ac58 on ixdy:nginx-ingress-controller-makefile into 3dd7461 on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants