Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup interface #837

Merged
merged 3 commits into from
Jun 12, 2017
Merged

Cleanup interface #837

merged 3 commits into from
Jun 12, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 11, 2017 •
edited
Loading

Removing Reload to not assume the implementations are running a process

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented Jun 11, 2017

@jcmoraisjr please check the first commit.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 46.543% when pulling 8a8e955 on aledbf:cleanup-interface into ecb9515 on kubernetes:master.

@aledbf aledbf merged commit 72f484e into kubernetes:master Jun 12, 2017
@jcmoraisjr
Copy link
Contributor

Thanks for pinging. Sounds good, will update ingress shortly and I send another PR if anything break.

@aledbf aledbf deleted the cleanup-interface branch June 13, 2017 04:14
@aledbf aledbf mentioned this pull request Aug 4, 2017
Merged
@joshrosso joshrosso mentioned this pull request Aug 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @k8s-reviewable @coveralls @jcmoraisjr @k8s-ci-robot