Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ingress annotation to enable upstream "keepalive" option #838

Closed
vdavidoff opened this issue Jun 11, 2017 · 3 comments · Fixed by #892
Closed

Feature request: Add ingress annotation to enable upstream "keepalive" option #838

vdavidoff opened this issue Jun 11, 2017 · 3 comments · Fixed by #892
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx

Comments

@vdavidoff
Copy link

In the latest NGINX release, 0.9.0-beta.7, there is no mention of the keepalive option from the upstream module. It'd be nice to be able to configure this, presumably with an annotation on an ingress resource. I'm thinking something like ingress.kubernetes.io/upstream-keepalive: {integer} (explicitly including upstream in the name to differentiate between this and the client<->server keepalive settings, though this could simply be ingress.kubernetes.io/keepalive).

I might wind up trying to implement this myself, but I figured I should go ahead and open the feature request regardless. I searched open issues and don't think I saw anything like this; apologies if this is a duplicate feature request.

@rikatz
Copy link
Contributor

rikatz commented Jun 12, 2017

@vdavidoff Let me know if you need any help implementing this :)

@aledbf aledbf added nginx enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 13, 2017
@aledbf
Copy link
Member

aledbf commented Jun 22, 2017

@vdavidoff let's start adding a global parameter in the configuration. We can add an annotation after we verify this works without issues.

@vdavidoff
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants