Simplify handling of ssl certificates #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Coverage decreased (-0.007%) to 44.334% when pulling 2c35ce251c0fa8cae980b559195d888685db23e4 on aledbf:force-reload into 26fccdc on kubernetes:master. |
|
I believe this causes logs for each Functionally seems ok. |
jcmoraisjr
reviewed
Jul 18, 2017
| glog.Warningf("ssl certificate for host %v is about to expire in 10 days", host) | ||
| } | ||
| if tlsSecretName == "" { | ||
| glog.Warningf("host %v is listed on tls section but secretName is empty. Using default cert", host) |
There was a problem hiding this comment.
@aledbf I do use wildcard domains and a wildcard certificate as the default cert. Using host without a secret is a feature on my deployment. Could this log be changed to V(3).Info?
There was a problem hiding this comment.
yes, there's already an open issue to increase the log leve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.