Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops update -f #2148

Closed
krisnova opened this issue Mar 19, 2017 · 7 comments
Closed

kops update -f #2148

krisnova opened this issue Mar 19, 2017 · 7 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@krisnova
Copy link
Contributor

krisnova commented Mar 19, 2017

Following up on #267:

It looks like we have a use case for

kops update -f

This would feel similar to kops create -f with the only difference being that it is intended to manage deltas and not create a cluster from scratch.

I think this would help users achieve the awesome goal of fully scripted kops management, and following the kubectl paradigm is a shoe-in.

Thoughts anyone?

CC @justinsb @geojaz @yissachar @chrislovecnm @k8s-mirror-aws-misc

@krisnova krisnova changed the title kops update -f kops update -f Mar 19, 2017
@chrislovecnm
Copy link
Contributor

How does this compare to kops replace -f?

@vinayagg
Copy link

I came here looking for 'update', found 'replace' instead.
I tested replace, it works perfectly as I think it should.

The only change can be to rename 'kops replace -f' with 'kops update -f' because

  • update is more intuitive
  • also, I was afraid that replacing with "node" ig yaml will destroy "cluster" and master ig yaml. However, it only replaced node yaml. So it is an update.

@chrislovecnm
Copy link
Contributor

I think we can just alias update to replace with cobra.

@kenden
Copy link
Contributor

kenden commented Apr 12, 2017

I seems update would be more logical, but according to the documentation, update does:
'creates or updates the cloud resources to match the cluster spec.'
(It does not 'update a cloud specification in the registry.`)

I thought the same as @vinayagg, that replace -f would destroy my existing cluster and create a new one. But maybe the problem is simply that there is no documentation about what replace does exactly:
https://github.com/kubernetes/kops/blob/master/docs/commands.md

@pavloos
Copy link

pavloos commented May 8, 2017

It would be great to be able to just have files with deltas and do kops update -f
Let's say I have and additional_policies.yaml containing just changes or additions

spec:
  additionalPolicies:
    master: |
      [
        [...]
      ]
     node: |
      [
        [...]
      ]

and want that merged with existing configuration.
Currently it does not seem possible as kops replace -f complains about missing objects (kind, then apiVersion and so on). Is it supposed to work and I am missing something or replace/update still requires full cluster config file ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@geojaz
Copy link
Member

geojaz commented Dec 26, 2017

/close

we dunnit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

8 participants