Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker 18.09.3 for Centos #7463

Closed
CarpathianUA opened this issue Aug 23, 2019 · 6 comments · Fixed by #7860
Closed

Docker 18.09.3 for Centos #7463

CarpathianUA opened this issue Aug 23, 2019 · 6 comments · Fixed by #7860

Comments

@CarpathianUA
Copy link

1. What kops version are you running? The command kops version, will display
this information.

1.13.0

2. What Kubernetes version are you running? kubectl version will print the
version if a cluster is running or provide the Kubernetes version specified as
a kops flag.

1.13.9

3. What cloud provider are you using?
AWS

According to that PR (merged) #6347 there is no possibility to use Docker 18.09.3 with RedHat-based distros. Is it true?

Appreciate your help!

@marsavela
Copy link
Contributor

As per https://github.com/kubernetes/kops/blob/master/nodeup/pkg/model/docker.go#L664 you have 18.09.3 only for Debian Stretch. I stumbled upon this because I am using Ubuntu and I also need it. 🤕

Let's see if I have time to at least test it for my Xenial needs.

@CarpathianUA
Copy link
Author

CarpathianUA commented Sep 9, 2019

Yes, exactly @marsavela
I also mentioned that. An it's really confusing me as well :)

@marsavela
Copy link
Contributor

@CarpathianUA May I ask why are you looking for 18.09.3 in particular?
You can find higher versions at https://download.docker.com/linux/centos/7/x86_64/stable/Packages/

I just did some testing with 18.09.9 in Xenial and worked as expected. I don't know if I should send a PR though. 😕

@CarpathianUA
Copy link
Author

Hi @marsavela ,
I'm looking especially for RedHat-based distros support (Centos/RHEL) for version >= 18.09.3.
Actually, according to https://github.com/kubernetes/kops/blob/master/nodeup/pkg/model/docker.go there is no support for such versions. Maybe I'll create a PR soon.

@marsavela
Copy link
Contributor

@CarpathianUA would be great if you can compile it and test it as well. Maybe we can ping some owners to know if PRs would be a good idea... According to the guidelines the repo owners would need to approve this. 🙄

Pinging @mikesplain since he's the one that merged the previous PR #6347

@marsavela
Copy link
Contributor

Bumping this back up. Maybe we can get an approval. I already have a branch for Ubuntu...

https://github.com/marsavela/kops/tree/docker-18.09.9

Adding @drekle as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants