-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the validation of unknown fields in configuration objects #1066
Comments
/assign @liztio @timothysc |
I'm ok with just a simple error message that makes it easy to grok. |
sig-api-machinery is working on this: kubernetes/kubernetes#67477 unfortunately it looks like the PR to double-upstream (ghodss/yaml) got rejected, so they're not targeting v1.12 anymore. I could write my own workaround, using |
@dims is trying again with ghodss/yaml#38, gonna call this blocked on that. |
We're going to have to punt this to 1.13 due to the dependency chain and 1.12 freeze. |
@bradfitz |
@neolit123, great, thanks for the update! |
a separate bug was discovered here when we found a typo in an etcd config field:
#1045
explanation here:
kubernetes/website#9802 (comment)
if
localEtcd
is passed instead oflocal
the parsing fails silently and we don't get an error from the api-machinery code.improve the validation for unknown fields.
adding this as a reminder here even if it belongs in another tracker.
@timothysc @bradfitz
The text was updated successfully, but these errors were encountered: