Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release branches e2e's should use k8s from release branches #237

Closed
pipejakob opened this issue Apr 11, 2017 · 7 comments
Closed

Release branches e2e's should use k8s from release branches #237

pipejakob opened this issue Apr 11, 2017 · 7 comments
Assignees
Labels
area/test kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@pipejakob
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT (of e2e test)

Our kubeadm e2e test that runs against the release-1.6 branch currently specifies --kubernetes-version latest when initializing the cluster. This is probably the correct behavior for our tests against the master branch, but this should really be latest-1.6 for the release-1.6 job, which will require new plumbing to kubetest.

Relevant part of kubetest: https://github.com/kubernetes/test-infra/blob/ab9c9911b771807f179e4cbab80b883042f27ba4/kubetest/anywhere.go#L53

The 1.6 job on testgrid: https://k8s-testgrid.appspot.com/release-1.6-blocking#kubeadm-gce-1.6

@luxas
Copy link
Member

luxas commented May 29, 2017

@pipejakob This is fixed, right?

@luxas luxas added area/test kind/bug Categorizes issue or PR as related to a bug. labels May 29, 2017
@luxas luxas added this to the v1.7 milestone May 29, 2017
@timothysc
Copy link
Member

@pipejakob ping.

@luxas
Copy link
Member

luxas commented Jun 13, 2017

@pipejakob ping

@pipejakob
Copy link
Contributor Author

This will be fixed by kubernetes/test-infra#2761. The reviewer requested some changes that I haven't had time to address yet. It's definitely in my queue.

@luxas luxas changed the title e2e release-1.6 using "latest" images Release branches e2e's should use k8s from release branches Jun 13, 2017
@luxas
Copy link
Member

luxas commented Jun 13, 2017

@pipejakob I updated the issue description to count both for v1.6 and v1.7

@pipejakob
Copy link
Contributor Author

@luxas
Copy link
Member

luxas commented Jun 17, 2017

Thank you a lot @pipejakob for fixing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants
@timothysc @pipejakob @luxas and others