kinder: optimize the preparation of upgrade artifacts #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the "altering" of the node image used by kinder, there are two two download stages, one to download the init artifacts and one to download upgrade artifacts. For some e2e workflows we have matching init and upgrade versions. This is done just to test the upgrade command and not perform an actual upgrade. It causes the same artifacts to be downloaded two times, which is slow. During the preparation of bits installers, check if the init/upgrade versions match. If so, tell the upgrade bits installer to use the init directory as install source. This results in just copying the bits from the host, instead of downloading them again.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/kinder
neolit123
added
priority/backlog
|
it's actually possible to see this change in action on top of this presubmit job log for this same PR: the artifacts for upgrade are just copied from init. so it works. |
neolit123
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
neolit123
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the "altering" of the node image used by kinder, there are two download stages, one to download the init artifacts and one to download upgrade artifacts.
For some e2e workflows we have matching init and upgrade versions. This is done just to test the upgrade command and not perform an actual upgrade. It causes the same artifacts to be downloaded two times, which is slow.
During the preparation of bits installers, check if the init/upgrade versions match. If so, tell the upgrade bits installer to use the init directory as install source. This results in just copying the bits from the host, instead of downloading them again.