Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinder: include "upgrade plan" as part of upgrade workflows #2971

Closed
neolit123 opened this issue Nov 24, 2023 · 0 comments · Fixed by #2973
Closed

kinder: include "upgrade plan" as part of upgrade workflows #2971

neolit123 opened this issue Nov 24, 2023 · 0 comments · Fixed by #2973
Assignees
@neolit123
Labels
area/kinder Issues to track work in the kinder tool area/test area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1.30

Comments

@neolit123
Copy link
Member

neolit123 commented Nov 24, 2023 •
edited
Loading

"upgrade plan" is only covered by unit tests which arguably suffices, but ideally we should call it when we are doing upgrades in kinder too.

https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-upgrade/#cmd-upgrade-plan
we should include all flags that allow experimental / pre-release versions, also propagate preflight errors.

"upgrade plan" must be called on control plane nodes where "apply" is called.

see what places must be updated in kinder code and CI workflows;
https://github.com/search?q=repo%3Akubernetes%2Fkubeadm+%22apply%22+path%3Akinder&type=code
@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/test kind/feature Categorizes issue or PR as related to a new feature. area/kinder Issues to track work in the kinder tool labels Nov 24, 2023
@neolit123 neolit123 added this to the v1.30 milestone Nov 24, 2023
@neolit123 neolit123 self-assigned this Nov 24, 2023
@neolit123 neolit123 mentioned this issue Nov 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
area/kinder Issues to track work in the kinder tool area/test area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1.30
Development

Successfully merging a pull request may close this issue.

kinder: call "upgrade plan" before "upgrade apply" neolit123/kubeadm
1 participant
@neolit123