Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should kubeadm have an assets abstraction? #49

Closed
mikedanese opened this issue Nov 22, 2016 · 4 comments
Closed

should kubeadm have an assets abstraction? #49

mikedanese opened this issue Nov 22, 2016 · 4 comments

Comments

@mikedanese
Copy link
Member

From @errordeveloper on October 3, 2016 12:0

It'd help to implement dry-run mode, tarball export or other things.

Copied from original issue: kubernetes/kubernetes#33926

@mikedanese
Copy link
Member Author

From @errordeveloper on October 3, 2016 12:21

We currently write files from every other function, and it's not exactly consistent how it happens and what helper funcs are used for doing it. However, in some cases this provides us with an ability to have more user-friendly error message, which is something we will need to ensure assets abstraction would be capable of. We shouldn't have to document files we write, if we have dry-run mode, or good logging etc. We could permit some files, e.g. PKI assets or static pods to exists on disk before kubeadm init, which would be convenient way of not having to implement too many extra flags...

@mikedanese
Copy link
Member Author

From @errordeveloper on October 3, 2016 12:23

We could add validation of existing files could also come into this, and even warn about deprecated files.

@mikedanese
Copy link
Member Author

From @luxas on October 25, 2016 20:35

@errordeveloper Can I close this?
It doesn't seem like we're going that way...

@luxas
Copy link
Member

luxas commented Nov 25, 2016

Closing, @errordeveloper comment if you strongly disagree...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants