Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need roundtrip, defaulting and validation unit tests between API versions #841

Closed
luxas opened this issue May 21, 2018 · 1 comment · Fixed by kubernetes/kubernetes#63917
Closed

We need roundtrip, defaulting and validation unit tests between API versions #841

luxas opened this issue May 21, 2018 · 1 comment · Fixed by kubernetes/kubernetes#63917
Assignees
@luxas
Labels
area/test area/upgrades lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.11

Comments

@luxas
Copy link
Member

luxas commented May 21, 2018

As part of kubernetes/community#2131, we have concluded we need roundtrip tests between API versions for our internal and external APIs. This combined with only a centralized place in the codebase that handles serialize/deserialize (cmd/kubeadm/app/util/marshal.go and cmd/kubeadm/app/util/config/*.go), will get us in a good place so these tests are virtually e2e test regarding how kubeadm responds to different configuration files given to it.

This is a priority for v1.11
@luxas luxas self-assigned this May 21, 2018
@luxas luxas added kind/enhancement priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/upgrades area/test lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels May 21, 2018
@luxas luxas added this to the v1.11 milestone May 21, 2018
@luxas luxas mentioned this issue May 21, 2018
Merged
@luxas
Copy link
Member Author

luxas commented May 21, 2018

Fixed by PR kubernetes/kubernetes#63917

@luxas luxas closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luxas luxas

Labels
area/test area/upgrades lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.11
1 participant
@luxas