Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kubeadm reset for 1.13 #971

Closed
neolit123 opened this issue Jul 4, 2018 · 6 comments
Closed

Improve kubeadm reset for 1.13 #971

neolit123 opened this issue Jul 4, 2018 · 6 comments
Assignees
Labels
area/UX lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@neolit123
Copy link
Member

1.12 planning doc:
https://docs.google.com/document/d/1YP8sCtgo58yqQ9sR4nsn9iuVFmglCCBMivCTwjd1ERE/edit#

we need better context for the set of tasks for this one.

@neolit123 neolit123 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/UX labels Jul 4, 2018
@neolit123 neolit123 added this to the v1.12 milestone Jul 4, 2018
@timothysc timothysc modified the milestones: v1.12, v1.13 Aug 25, 2018
@rosti
Copy link

rosti commented Aug 31, 2018

@timothysc
Copy link
Member

@rosti The general theme is kubeadm reset is not consistent on the cleanup.

1 - issue WRT iptables rules imo is outside the scope of kubeadm and falls on the proxy. But that doesn't mean that the proxy shouldn't support a cleanup option that kubeadm can call.

the other CRI cleanup issues definitely is in our wheelhouse.

@timothysc
Copy link
Member

/assign @rosti
/unassign @timothysc

@k8s-ci-robot k8s-ci-robot assigned rosti and unassigned timothysc Aug 31, 2018
@timothysc timothysc modified the milestones: v1.12, v1.13 Sep 5, 2018
@fabriziopandini
Copy link
Member

Orthogonal to container cleanup we can improve kubeadm reset us by reading the crisocket from the node (instead of forcing the user to the user to re-pass the --criSocket flag)

@rosti
Copy link

rosti commented Sep 5, 2018

As this is moved to 1.13 we can improve a lot. There is some Linux specific stuff, some hard coded paths, etc. which could not be addressed for 1.12 since they were not bugs (leftovers from reset).

@neolit123 neolit123 changed the title Improve kubeadm reset for 1.12 Improve kubeadm reset for 1.13 Sep 18, 2018
@timothysc timothysc added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 30, 2018
@timothysc
Copy link
Member

closing due to other issues for tracking and other PRs are already in for 1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants