Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client-go fake delete, update and create option tracking #129738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix client-go fake delete, update and create option tracking #129738

wants to merge 2 commits into from

Conversation

bigkevmcd
Copy link

@bigkevmcd bigkevmcd commented Jan 21, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This fixes the fake dynamic client Create, Update and Delete methods to ensure that the provided Options are recorded in the created fake action.

Which issue(s) this PR fixes:

Fixes #129737

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and liggitt January 21, 2025 21:07
@bigkevmcd
Copy link
Author

The .Update() and .Create() methods have the same bug.

I'm happy to fix this in the same branch, or open a new issue.

@bigkevmcd bigkevmcd force-pushed the fix-client-fo-fake-delete-options branch from d0bc906 to 901623a Compare January 22, 2025 20:26
@seans3
Copy link
Contributor

seans3 commented Jan 23, 2025

/ok-to-test
/triage accept
/assign @aaron-prindle

@k8s-ci-robot
Copy link
Contributor

@seans3: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/ok-to-test
/triage accept
/assign @aaron-prindle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2025
@seans3
Copy link
Contributor

seans3 commented Jan 23, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2025
@aaron-prindle
Copy link
Contributor

/retest

@bigkevmcd bigkevmcd changed the title Fix client-go fake delete tracking Fix client-go fake delete, update and create option tracking Jan 29, 2025
@bigkevmcd
Fix client-go fake dynamic client recording options
7cca692 
This fixes the fake dynamic client  to ensure that the
Options are recorded in the created fake action.

Signed-off-by: Kevin McDermott <bigkevmcd@gmail.com>
@bigkevmcd bigkevmcd force-pushed the fix-client-fo-fake-delete-options branch from 901623a to 228b273 Compare February 5, 2025 18:41
@bigkevmcd
Add additional fake client tests.
cd71561 
Add tests for Create, Update, Delete with no options.

Signed-off-by: Kevin McDermott <bigkevmcd@gmail.com>
@bigkevmcd bigkevmcd force-pushed the fix-client-fo-fake-delete-options branch from 228b273 to cd71561 Compare February 5, 2025 18:41
@aaron-prindle
Copy link
Contributor

/lgtm

/approve @jpbetz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a91c7298be81f47c5db459797772548c650a081

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aaron-prindle, bigkevmcd
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle left review comments

@aojea aojea Awaiting requested review from aojea

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@aaron-prindle aaron-prindle

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client-go dynamic fake client doesn't record deletion options
4 participants
@bigkevmcd @k8s-ci-robot @seans3 @aaron-prindle