reload does not work for "docker" inisde minikube

[medyagh]

tested in docker driver:

docker@minikube:~$ sudo systemctl reload  docker
Job for docker.service failed.
See "systemctl status docker.service" and "journalctl -xe" for details.

journalctl

-- Startup of the manager took 1563911 microseconds.
Dec 22 22:38:27 minikube dockerd[176]: time="2020-12-22T22:38:27.674859891Z" level=info msg="API listen on /run/docker.sock"
Dec 22 22:38:32 minikube sshd[283]: Accepted publickey for docker from 192.168.49.1 port 61302 ssh2: RSA SHA256:5/JpqVCuJQD3QlhxIVAavZVh95U71wJvqkt2htnJpRs
Dec 22 22:38:32 minikube sshd[285]: Accepted publickey for docker from 192.168.49.1 port 61306 ssh2: RSA SHA256:5/JpqVCuJQD3QlhxIVAavZVh95U71wJvqkt2htnJpRs
Dec 22 22:38:32 minikube sudo[290]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/hostname minikube
Dec 22 22:38:32 minikube sudo[290]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:32 minikube sudo[290]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:32 minikube sudo[290]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:32 minikube sudo[293]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/tee /etc/hostname
Dec 22 22:38:32 minikube sudo[293]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:32 minikube sudo[293]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:32 minikube sudo[293]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:33 minikube sshd[295]: Accepted publickey for docker from 192.168.49.1 port 61310 ssh2: RSA SHA256:5/JpqVCuJQD3QlhxIVAavZVh95U71wJvqkt2htnJpRs
Dec 22 22:38:33 minikube sshd[297]: Accepted publickey for docker from 192.168.49.1 port 61314 ssh2: RSA SHA256:5/JpqVCuJQD3QlhxIVAavZVh95U71wJvqkt2htnJpRs
Dec 22 22:38:33 minikube sshd[303]: Accepted publickey for docker from 192.168.49.1 port 61318 ssh2: RSA SHA256:5/JpqVCuJQD3QlhxIVAavZVh95U71wJvqkt2htnJpRs
Dec 22 22:38:33 minikube sudo[306]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/mkdir -p /etc/docker /etc/docker /etc/docker
Dec 22 22:38:33 minikube sudo[306]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:33 minikube sudo[306]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:33 minikube sudo[306]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:33 minikube sudo[309]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/test -d /etc/docker
Dec 22 22:38:33 minikube sudo[309]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:33 minikube sudo[309]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:33 minikube sudo[309]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:33 minikube sudo[311]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/scp -t /etc/docker
Dec 22 22:38:33 minikube sudo[311]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:33 minikube sudo[311]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:33 minikube sudo[311]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:33 minikube sudo[308]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/touch -d 2020-12-22 14:38:33.491665051 -0800 /etc/docker/server-key.pem
Dec 22 22:38:33 minikube sudo[308]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directory
Dec 22 22:38:33 minikube sudo[308]: pam_unix(sudo:session): session opened for user root by (uid=0)
Dec 22 22:38:33 minikube sudo[308]: pam_unix(sudo:session): session closed for user root
Dec 22 22:38:33 minikube sudo[315]:   docker : TTY=unknown ; PWD=/home/docker ; USER=root ; COMMAND=/usr/bin/test -d /etc/docker
Dec 22 22:38:33 minikube sudo[315]: pam_env(sudo:session): Unable to open env file: /etc/default/locale: No such file or directo

status after:

docker@minikube:~$ sudo systemctl status  docker        
● docker.service - Docker Application Container Engine
     Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2020-12-22 22:38:35 UTC; 15min ago
TriggeredBy: ● docker.socket
       Docs: https://docs.docker.com
    Process: 5146 ExecReload=/bin/kill -s HUP (code=exited, status=1/FAILURE)
   Main PID: 422 (dockerd)
      Tasks: 17
     Memory: 55.5M
     CGroup: /docker/7950849a46c7bfb6927de64b41fc8f920b98b7e513e1eb2edfc0dbfe73a940e4/system.slice/docker.service
             └─422 /usr/bin/dockerd -H tcp://0.0.0.0:2376 -H unix:///var/run/docker.sock --default-ulimit=nofile=1048576:1048576 --tlsverify --tlscacert /etc/docker/ca.pem --tlscert /etc/docker/server.pem --tlskey
 /etc/docker/server-key.pem --label provider=docker --insecure-registry 10.96.0.0/12

Dec 22 22:49:39 minikube kill[5146]:  <pid> [...]            send signal to every <pid> listed
Dec 22 22:49:39 minikube kill[5146]:  -<signal>, -s, --signal <signal>
Dec 22 22:49:39 minikube kill[5146]:                         specify the <signal> to be sent
Dec 22 22:49:39 minikube kill[5146]:  -l, --list=[<signal>]  list all signal names, or convert one to a name
Dec 22 22:49:39 minikube kill[5146]:  -L, --table            list all signal names in a nice table
Dec 22 22:49:39 minikube kill[5146]:  -h, --help     display this help and exit
Dec 22 22:49:39 minikube kill[5146]:  -V, --version  output version information and exit
Dec 22 22:49:39 minikube kill[5146]: For more details see kill(1).
Dec 22 22:49:39 minikube systemd[1]: docker.service: Control process exited, code=exited, status=1/FAILURE
Dec 22 22:49:39 minikube systemd[1]: Reload failed for Docker Application Container Engine.

[medyagh]

@azhao155 found out
the source of problem seem to be this line not getting intereprted

this is causing un-nessscary restarting containers, when we are suppoed to only reload it
https://github.com/medyagh/minikube/blob/75cd17801287339a00efe44fbd451b4dbfadef86/pkg/provision/ubuntu.go#L112

[azhao155]

/assign azhao155

[azhao155]

#10027

[medyagh]

fixed by #10027