Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore BUILD_IMAGE value to 'kube-cross' #10276

Closed
ilya-zuyev opened this issue Jan 26, 2021 · 2 comments · Fixed by #10691
Closed

Restore BUILD_IMAGE value to 'kube-cross' #10276

ilya-zuyev opened this issue Jan 26, 2021 · 2 comments · Fixed by #10691
Assignees
@ilya-zuyev
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v.1.19.0

Comments

@ilya-zuyev
Copy link
Contributor

#10202 changed default BUILD_IMAGE value from us.gcr.io/k8s-artifacts-prod/build-image/kube-cross:v$(GO_VERSION)-1 to golang:1.16beta1-buster to be able to build for darwin/arm64

We need to return back to kube-cross when it supports go 1.16
@ilya-zuyev
Copy link
Contributor Author

/assign

@ilya-zuyev ilya-zuyev added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 27, 2021
@medyagh
Copy link
Member

medyagh commented Mar 2, 2021

as part of this task I recommend updating go.mod to 1.16 too so we can start using the go embed instead of go-bindata

@medyagh medyagh added this to the v.1.19.0 milestone Mar 2, 2021
@ilya-zuyev ilya-zuyev mentioned this issue Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-zuyev ilya-zuyev

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v.1.19.0
Development

Successfully merging a pull request may close this issue.

restore kube-cross build image and bump go to version 1.16 ilya-zuyev/minikube
2 participants
@medyagh @ilya-zuyev