Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository and tag for CoreDNS changed in 1.8.0 (Kubernetes 1.21) #11424

Closed
afbjorklund opened this issue May 16, 2021 · 1 comment · Fixed by #11426
Closed

Repository and tag for CoreDNS changed in 1.8.0 (Kubernetes 1.21) #11424

afbjorklund opened this issue May 16, 2021 · 1 comment · Fixed by #11426
Labels
co/coredns CoreDNS related issues co/preload kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented May 16, 2021

Error response from daemon: manifest for k8s.gcr.io/coredns:1.8.0 not found: manifest unknown: Failed to fetch "1.8.0" from request "/v2/coredns/manifests/1.8.0".

kubernetes/kubernetes@40862c3

--- a/cmd/kubeadm/app/constants/constants.gopkg/minikube/bootstrapper/images/images.go
+++ b/cmd/kubeadm/app/constants/constants.go
@@ -323,7 +323,7 @@ const (
        CoreDNSDeploymentName = "coredns"
 
        // CoreDNSImageName specifies the name of the image for CoreDNS add-on
-       CoreDNSImageName = "coredns"
+       CoreDNSImageName = "coredns/coredns"
 
        // KubeDNSConfigMap specifies in what ConfigMap in the kube-system namespace the kube-dns config should be stored
        KubeDNSConfigMap = "kube-dns"
@@ -344,7 +344,7 @@ const (
        KubeDNSVersion = "1.14.13"
 
        // CoreDNSVersion is the version of CoreDNS to be deployed if it is used
-       CoreDNSVersion = "1.7.0"
+       CoreDNSVersion = "v1.8.0"
 
        // ClusterConfigurationKind is the string kind value for the ClusterConfiguration struct
        ClusterConfigurationKind = "ClusterConfiguration"

So this change needs to be reflected in the minikube code as well.

func coreDNS(v semver.Version, mirror string) string
@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. co/preload co/coredns CoreDNS related issues labels May 16, 2021
@afbjorklund
Copy link
Collaborator Author

Possibly related to #11290 which changes how the bootstrapper images for kubeadm work.

@afbjorklund afbjorklund changed the title Repository and tag for CoreDNS changed in 1.8.0 (kubernetes 1.21) Repository and tag for CoreDNS changed in 1.8.0 (Kubernetes 1.21) May 16, 2021
@spowelljr spowelljr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/coredns CoreDNS related issues co/preload kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants