Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker container runtime in Kubernetes 1.24 #13545

Closed
afbjorklund opened this issue Feb 2, 2022 · 3 comments · Fixed by #13563
Closed

Support docker container runtime in Kubernetes 1.24 #13545

afbjorklund opened this issue Feb 2, 2022 · 3 comments · Fixed by #13563
Assignees
Labels
co/runtime/docker Issues specific to a docker runtime priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 2, 2022

This is a tracker for the required changes:

minikube start --kubernetes-version=v1.24.0-alpha.2 --container-runtime=docker

Failing with minikube v1.25.1, due to the earlier confusion about the socket name

ISO (missing)

Failed to enable unit: Unit file cri-docker.socket does not exist.

KIC (outdated)

stat: cannot stat '/var/run/cri-dockerd.sock': No such file or directory
docker@minikube:~$ systemctl cat cri-docker.socket 
# /lib/systemd/system/cri-docker.socket
[Unit]
Description=CRI Docker Socket for the API
PartOf=cri-docker.service

[Socket]
ListenStream=%t/cri-docker.sock
SocketMode=0660
SocketUser=root
SocketGroup=docker

[Install]
WantedBy=sockets.target
docker@minikube:~$ cri-dockerd --version
cri-dockerd 0.2.0 (HEAD)
@@ -3,7 +3,7 @@ Description=CRI Docker Socket for the API
 PartOf=cri-docker.service
 
 [Socket]
-ListenStream=%t/cri-docker.sock
+ListenStream=%t/cri-dockerd.sock
 SocketMode=0660
 SocketUser=root
 SocketGroup=docker

Still wrong in the upstream README, but there it is the unit and not the file.

@afbjorklund

This comment was marked as outdated.

@afbjorklund afbjorklund added co/runtime/docker Issues specific to a docker runtime priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 2, 2022
@afbjorklund
Copy link
Collaborator Author

v1.24.0-alpha.1

	// DefaultDockerCRISocket defines the default Docker CRI socket
	DefaultDockerCRISocket = "/var/run/dockershim.sock"

v1.24.0-alpha.2

	// CRISocketDocker is the cri-dockerd CRI endpoint
	CRISocketDocker = "unix:///var/run/cri-dockerd.sock"

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Feb 4, 2022

My bad, thought the socket path fix was included in v0.2.0 but it was in v0.2.0-7-g3eee3e4

Can go straight for v0.2.0-11-ga4d1895 and get some fixes for the README and --buildinfo ?

EDIT: The build script for cri-dockerd is broken, so the VERSION and REVISION are not propagated.

Will need to hack something to avoid clobbering LDFLAGS and GO_VERSION in the Makefiles...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/docker Issues specific to a docker runtime priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant