Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: enable CONFIG_PROC_CHILDREN kernel configuration option for the VirtualBox VM #14351

Closed
rm3l opened this issue Jun 19, 2022 · 8 comments · Fixed by #14689
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@rm3l
Copy link
Contributor

rm3l commented Jun 19, 2022

What Happened?

Hi there!

We have an existing tool that runs in containers and relies on the /proc pseudo-filesystem to retrieve children processes of any given parent process. It leverages the /proc/[pid]/task/[tid]/children file, the presence of which is governed by a CONFIG_PROC_CHILDREN kernel config option on the host running those containers [1]

While this works great on most environments, we tested recently with Minikube (using the VirtualBox driver), and noticed that this file was missing because the kernel of the Minikube VirtualBox VM surprisingly does not set this config:

$ minikube ssh
$ zgrep CONFIG_PROC_CHILDREN /proc/config.gz                             
# CONFIG_PROC_CHILDREN is not set

We worked around this by building a custom minikube ISO, but I was wondering if it wouldn't make more sense to have this set as a default config instead.

If you think this makes sense, I can happily try to contribute a PR :-)

Thanks.

[1] https://man7.org/linux/man-pages/man5/proc.5.html

Attach the log file

log.txt

Operating System

Redhat/Fedora

Driver

VirtualBox

@RA489
Copy link

RA489 commented Jun 22, 2022

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Jun 22, 2022
@spowelljr
Copy link
Member

Hi @rm3l, thank you for your issue, I'm happy to accept a PR that enables the configuration option.

@spowelljr spowelljr added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/support Categorizes issue or PR as a support question. labels Jul 27, 2022
@rm3l
Copy link
Contributor Author

rm3l commented Jul 27, 2022

Hi @rm3l, thank you for your issue, I'm happy to accept a PR that enables the configuration option.

Thanks for your feedback, @spowelljr ! I'll look into this when I get some time.

@klaases
Copy link
Contributor

klaases commented Oct 5, 2022

Hi @rm3l, are you still interested in working on this issue?

@rm3l
Copy link
Contributor Author

rm3l commented Oct 6, 2022

are you still interested in working on this issue?

@klaases Yeah definitely. I opened up a PR (#14689) a few months back to fix this issue. It has already been approved, but I am not sure what remains to be done from my standpoint. That was the point of my question asked in #14689 (comment) a few days ago.
Thanks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@rm3l
Copy link
Contributor Author

rm3l commented Feb 22, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants