Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello-minikube incorrect image #15086

Closed
michaldorsett opened this issue Oct 7, 2022 · 2 comments · Fixed by #15397
Closed

hello-minikube incorrect image #15086

michaldorsett opened this issue Oct 7, 2022 · 2 comments · Fixed by #15397
Assignees
@spowelljr
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@michaldorsett
Copy link

The image specified at https://minikube.sigs.k8s.io/docs/start/ is ocker.io/nginx:1.23.
However, the landing page on this image is the "Welcome to Nginx" page, instead of the one show "CLIENT VALUES", "SERVER VALUES", etc.
The basic controls page does specify the correct image: k8s.gcr.io/echoserver:1.4.
@afbjorklund
Copy link
Collaborator

The "correct image" needs replacing:

@afbjorklund afbjorklund added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 9, 2022
@spowelljr
Copy link
Member

spowelljr commented Oct 13, 2022 •
edited
Loading

We changed the image to docker.io/nginx:1.23 because as @afbjorklund pointed out the existing image didn't run on arm64. So to stop the flow of issues from people having troubles on arm64 we replaced it with docker.io/nginx:1.23. However I seem to have missed the line below talking about the response values from the previous image.

@spowelljr spowelljr self-assigned this Nov 23, 2022
@spowelljr spowelljr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 23, 2022
@spowelljr spowelljr mentioned this issue Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

site: Update echo-server image spowelljr/minikube
3 participants
@afbjorklund @michaldorsett @spowelljr