Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-env support for Windows paths in WSL shell #3248

Closed
cryptable opened this issue Oct 13, 2018 · 5 comments
Closed

docker-env support for Windows paths in WSL shell #3248

cryptable opened this issue Oct 13, 2018 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. os/windows priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2

Comments

@cryptable
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Please provide the following details:

Environment: Windows 10 with Windows Subsystem for Linux (Ubuntu 16.04.4 LTS)

Minikube version (use minikube version): v0.30.0

  • OS (e.g. from /etc/os-release): Windows 10 with Windows Subsystem for Linux (Ubuntu 16.04.4 LTS)
  • VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): hyperv
  • ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.30.0
  • Install tools: Chocolatey
  • Others:

What happened:

>minikube docker-env --shell bash
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.2.42:2376"
export DOCKER_CERT_PATH=**"C:\Users\goobligoog\.minikube\certs"**
export DOCKER_API_VERSION="1.35"
# Run this command to configure your shell:
# eval $(minikube docker-env)

What you expected to happen:

>minikube docker-env --shell bash
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.2.42:2376"
export DOCKER_CERT_PATH=**"/mnt/c/Users/goobligoog/.minikube/certs"**
export DOCKER_API_VERSION="1.35"
# Run this command to configure your shell:
# eval $(minikube docker-env)

How to reproduce it (as minimally and precisely as possible):
see above

Output of minikube logs (if applicable):
Not applicable

Anything else do we need to know:
Would be nice to have a command as follows:

>minikube docker-env --shell wsl
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.2.42:2376"
export DOCKER_CERT_PATH=**"/mnt/c/Users/goobligoog/.minikube/certs"**
export DOCKER_API_VERSION="1.35"
# Run this command to configure your shell:
# eval $(minikube docker-env --shell wsl)

Just and idea! So you can reuse your Linux development on Windows 10 with WSL and reuse it as a command:

eval $(minikube docker-env --shell wsl)

Maybe you can detect if your under WSL on Windows 10

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. os/windows labels Oct 30, 2018
@tstromberg tstromberg added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@tstromberg tstromberg added r/2019q2 Issue was last reviewed 2019q2 priority/backlog Higher priority than priority/awaiting-more-evidence. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels May 17, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2019
@tstromberg tstromberg changed the title Minikube on Windows 10 with Windows Subsystem for Linux (WSL) minikube docker-env support for WSL shell Sep 19, 2019
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 19, 2019
@tstromberg tstromberg changed the title minikube docker-env support for WSL shell docker-env support for WSL shell Sep 19, 2019
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Sep 19, 2019
@tstromberg tstromberg changed the title docker-env support for WSL shell docker-env support for Windows paths in WSL shell Sep 19, 2019
@tstromberg
Copy link
Contributor

tstromberg commented Sep 20, 2019

PR's welcome! Here's the code:

func shellCfgSet(api libmachine.API) (*ShellConfig, error) {

@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 16, 2019
@medyagh
Copy link
Member

medyagh commented Aug 12, 2020

@cryptable have you tried with latest version of minikube I believe it must have been fixed by the PR that added WSL support

#5392

@medyagh medyagh closed this as completed Aug 12, 2020
@medyagh medyagh reopened this Aug 12, 2020
@medyagh
Copy link
Member

medyagh commented Feb 18, 2021

since latest version of minikube we disallow running the .exe binary in WSL, inside WLS plz use the Linux Binary

@medyagh medyagh closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. os/windows priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Development

No branches or pull requests

5 participants