Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: setting minikube profile should set k8s current context . #4503

Closed
medyagh opened this issue Jun 15, 2019 · 0 comments · Fixed by #4504
Closed

Feature: setting minikube profile should set k8s current context . #4503

medyagh opened this issue Jun 15, 2019 · 0 comments · Fixed by #4504
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Jun 15, 2019 •
edited
Loading

minikube version:

minikube version: v1.1.1

problem:

when changing profile, it doesn't change the k8s context.

reproduce:

  • Create two profiles p1,p2
minikube start -p p1 --vm-driver virtualbox
minikube start -p p2 --vm-driver virtualbox
  • set the profile to p1: minikube profile p1
$ minikube profile p1 --alsologtostderr -v=8
I0615 16:11:49.939954   94839 notify.go:128] Checking for updates...
✅  minikube profile was successfully set to p1

the kubectl context:

$ kubectl config current-context
p2
  • expect the context to be p1 but it is still p2. (it only gets set by start cmd)

os : mac os high sierra 10.13.6
@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jun 16, 2019
@medyagh medyagh changed the title minikube profile doesn't set kubernetes context correctly. minikube profile doesn't set kubernetes context . Jun 16, 2019
@medyagh medyagh added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 16, 2019
@medyagh medyagh changed the title minikube profile doesn't set kubernetes context . setting minikube profile should set kubectl current context . Jun 16, 2019
@medyagh medyagh mentioned this issue Jun 16, 2019
Merged
@medyagh medyagh changed the title setting minikube profile should set kubectl current context . Feature: setting minikube profile should set k8s current context . Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch kubectl current-context on profile change medyagh/minikube
1 participant
@medyagh