Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trandalation file load error #4549

Closed
djmgit opened this issue Jun 21, 2019 · 4 comments
Closed

Trandalation file load error #4549

djmgit opened this issue Jun 21, 2019 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@djmgit
Copy link
Contributor

djmgit commented Jun 21, 2019

The exact command to reproduce the issue:

Any minikube command

for example:
minikube profile

All minikube commands are throwing the error :
E0621 12:57:44.947127 1086 translate.go:80] Failed to load transalation file for [locale]: open pkg/minikube/translate/translations/[respective_locale_file].json: no such file or directory. before proceeding further.

Is there not a better way to deal with this error rather than displaying it with every minikube command.
The operating system version:
ubuntu 18.04

@djmgit
Copy link
Contributor Author

djmgit commented Jun 21, 2019

@medyagh @afbjorklund views?

@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 21, 2019
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jun 21, 2019

It's actually worse than just spewing error messages, it is also failing to compile the translations into the minikube binary (the only thing that we are actually installing) and then looking for a random runtime file:
Failed to load transalation file for sv-SE: open pkg/minikube/translate/translations/sv-SE.json: no such file or directory

Oh, and the error message has a typo.

Got broken with #4464

@sharifelgamal
Copy link
Collaborator

I'll suppress the error, since we can't be expected to have every translation file for every locale yet. I'll add the translation files into the binary early next week.

@afbjorklund
Copy link
Collaborator

@sharifelgamal : Thanks, the error is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants