-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose smarter defaults for --memory #5021
Comments
This should leave some room for multi-node as well (eventually) ? Currently starting 4 VMs, which is 8G (when did the “2.25” happen?) Some hypervisors can do “ballooning” and adjust memory on the fly (or more like give back what they stole from the real OS, but) |
@tstromberg Do you have any idea how we can get the current available memory size? |
@Zyqsempai - It's unclear if gopsutil, which we already have imported, gives us what we need. I worry that it may be conflating physical memory with swap: https://github.com/shirou/gopsutil#usage As an alternative, there is: https://github.com/pbnjay/memory |
I thought swap was in a separate Stat ? But haven’t actually verified |
Related to #94 |
Did we find out where the extra 0.25 came from ? i.e. why it requires even more memory now |
While working with @priyawadhwa on a demo, I noticed that minikube was locking up. Increasing the memory size fixed the problem. Also, the first thing our documentation states after installation is to increase the memory size.
What if we were able to improve the first-start experience for most users by default, by dynamically selecting a more appropriate option for
--memory
?My recommendation is to change the default 2GB setting to 37.5% of available memory by default: but never less than 2.25GB or more than 8GB. For instance:
The balance can be fine tuned, but my main argument is that a developer on a 16GB machine can probably live with a 6GB VM.
The text was updated successfully, but these errors were encountered: