Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make buildroot provision package re-usable for kic #6485

Closed
medyagh opened this issue Feb 4, 2020 · 0 comments · Fixed by #6487
Closed

make buildroot provision package re-usable for kic #6485

medyagh opened this issue Feb 4, 2020 · 0 comments · Fixed by #6487
Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 4, 2020

while debugging kic driver that why crictl can not list images in docker I found out the /etc/crictl.yaml is not pointing to the docker.sock and docker sytemd config looks different !
on VM it is

   CGroup: /system.slice/docker.service
           ├─1908 /usr/bin/dockerd -H tcp://0.0.0.0:2376 -H unix:///var/run/docker.sock --default-ulimit=nofile=1048576:1048576 --tlsverify --tlscacert /etc/docker/ca.pem --tlscert /etc/docker/server.pem --tlskey /etc/docker/server-key.pem --label provider=hyperkit --insecure-registry 10.96.0.0/12

but it in container its naked and not configured.

the provision package configures our dockerd
https://github.com/kubernetes/minikube/blob/master/pkg/provision/buildroot.go

has useful functions that could be used for both VM and container
for example: https://github.com/kubernetes/minikube/blob/master/pkg/provision/buildroot.go#L90
this function generates systemd files for docker. which inncludes insecure regteries...
which is used by VM but we should make this package agonistic of VM or Container.

@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 4, 2020
@medyagh medyagh changed the title make buildroot provision package re-usable make buildroot provision package re-usable for kic Feb 4, 2020
@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant