Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube config set vm-driver ignored #7091

Closed
tstromberg opened this issue Mar 18, 2020 · 3 comments · Fixed by #7109
Closed

minikube config set vm-driver ignored #7091

tstromberg opened this issue Mar 18, 2020 · 3 comments · Fixed by #7109
Assignees
@priyawadhwa
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.9.0 March 24th

Comments

@tstromberg
Copy link
Contributor

Related to #7078 #7079
@tstromberg
Copy link
Contributor Author

NOTE: This is likely due to us renaming vm-driver to driver.

@tstromberg tstromberg added this to the v1.9.0 March 24th milestone Mar 18, 2020
@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Mar 18, 2020
@tstromberg
Copy link
Contributor Author

tstromberg commented Mar 18, 2020 •
edited
Loading 

% minikube config set vm-driver virtualbox
❗  These changes will take effect upon a minikube delete and then a minikube start

% minikube start
😄  minikube v1.9.0-beta.1 on Darwin 10.15.3
✨  Automatically selected the hyperkit driver. Other choices: virtualbox, vmwarefusion

@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 18, 2020
@priyawadhwa
Copy link

I was able to repro this and had this in my config.json:

{
    "driver": "hyperkit",
    "vm-driver": "virtualbox"
}

we check if driver is set first so I was getting hyperkit. If both are set, we should probably output a warning to the user.

@priyawadhwa priyawadhwa mentioned this issue Mar 19, 2020
Merged
@priyawadhwa priyawadhwa self-assigned this Mar 19, 2020
@afbjorklund afbjorklund mentioned this issue Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyawadhwa priyawadhwa

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.9.0 March 24th
Development

Successfully merging a pull request may close this issue.

Add warning if both vm-driver and driver are specified priyawadhwa/minikube
2 participants
@tstromberg @priyawadhwa