Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-node: unable to choose CNI (always applies kindnet) #8222

Closed
sharifelgamal opened this issue May 20, 2020 · 1 comment · Fixed by #8545
Closed

multi-node: unable to choose CNI (always applies kindnet) #8222

sharifelgamal opened this issue May 20, 2020 · 1 comment · Fixed by #8545
Assignees
Labels
area/cni CNI support co/multinode Issues related to multinode clusters kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@sharifelgamal
Copy link
Collaborator

sharifelgamal commented May 20, 2020

Right now we enforce our own CNI for multinode clusters, ignoring any input from the user. We should respect the --enable-default-cni parameter and not apply CNI when that's false.

@sharifelgamal sharifelgamal added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/cni CNI support co/multinode Issues related to multinode clusters labels May 20, 2020
@sharifelgamal sharifelgamal added this to the v.1.12.0 milestone May 20, 2020
@tstromberg tstromberg modified the milestones: v.1.12.0-candidate, v1.12.0-realc Jun 1, 2020
@tstromberg
Copy link
Contributor

The TL;DR is that CNI in minikube is very confusing.

Here is my rough proposal, which would also help address #1568

  • Change --enable-default-cni (bool) flag to --cni (string).

    • none: no CNI. The current default for minikube.
    • kindnet: The current default for minikube if -n or --driver=docker is used.
    • flannel: kindnet alternative.
    • custom: bring your own CNI (for backwards compat, will also respect true).
  • Add alias for --enable-default-cni to --cni.

If things look good, I also feel that --cni=kindnet should be the default for all clusters.

@tstromberg tstromberg changed the title Let users supply their own CNI for multinode multi-node: unable to choose CNI (always applies kindnet) Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cni CNI support co/multinode Issues related to multinode clusters kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
2 participants