Add transient states ("stopping", "starting")

[kschaab]

Minikube status lists Running, Paused or Stopped for each profile. It does not account for the state between minikube start and Running. It would be helpful to indicate when minikube is starting, pausing (maybe, this state seems like it might be super short), stopping and possibly deleting as well as valid states.

[medyagh]

seems like a good feature for minikube !

[tstromberg]

"downloading" could also be a good state

[tharun208]

I like to work on this @tstromberg

[medyagh]

@tharun208 I would be happy to review a PR that doe this. do you think you can make it for v1.13.0 on Aug 4th?

[tstromberg]

@tharun208 - please confirm if you would still like to take this on. Here is my initial naive implementation idea:

• Create a new file (for example, ~/.minikube/profiles/<name>/state.json) containing a simple JSON file with a field like:

{ status = "starting" }

• Add a Status function here that returns the path. You can use ConfigFile() as a reference to copy:

minikube/pkg/minikube/localpath/localpath.go

Line 39 in c6000e6

• Add code to

  minikube/pkg/minikube/machine/host.go

  Line 28 in c6000e6

  func Status(api libmachine.API, machineName string) (string, error) {

  that references the state output by this file. I'd probably start by ignoring this file if it's modification time is older than 1 minute.

• Add a method in the same package that allows you to update the state file

• Add code to

  minikube/pkg/minikube/machine/start.go

  Line 66 in c6000e6

  func StartHost(api libmachine.API, cfg *config.ClusterConfig, n *config.Node) (*host.Host, bool, error) {

  to set the state to Starting

• Add code to

  minikube/pkg/minikube/machine/stop.go

  Line 35 in c6000e6

  func StopHost(api libmachine.API, machineName string) error {

  to set the state to Stopping.

Other ideas, though I wouldn't necessarily worry about them for the initial implementation, are Downloading and Deleting.

[tstromberg]

If I haven't heard anything back later today from @tharun208, I'd like to work on this, as it's blocking one of our users (Cloud Code).

One new idea I had is that @priyawadhwa built the concept of "steps" into minikube, for emitting CloudEvent JSON output:

minikube/pkg/minikube/machine/start.go

Line 261 in 5223979

register.Reg.SetStep(register.CreatingContainer)

I think we should build on this by introducing a concept of state transitions, and storing the combined state transition & step into the status file. For instance:

state.Transition(state.Starting, register.CreatingContainer, message)

Could emit the appropriate output.

[priyawadhwa]

@tstromberg instead of passing in the specific step register.CreatingContainer, you could access the current step via:

register.Reg.CurrentStep()

that way you could rely on the steps that have already been set in the register instead of having to uniquely pass them in again

[tharun208]

@medyagh, I think I can't make it for the next release. @tstromberg, you can pick this

[tstromberg]

Thanks for the heads up @tharun208. I'm sure this feature will require future refinement where we could use your hepl.

[tstromberg]

I have some ideas on this, and intend to have an initial PR for review tomorrow, with a target to merge by EOW.